linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>
Subject: Re: Can we ignore frames with invalid BSSID in IBSS mode?
Date: Wed, 30 Sep 2015 10:20:51 -0700	[thread overview]
Message-ID: <560C19F3.6070903@candelatech.com> (raw)
In-Reply-To: <1443633267.1859.11.camel@sipsolutions.net>

On 09/30/2015 10:14 AM, Johannes Berg wrote:
> On Wed, 2015-09-30 at 08:44 -0700, Ben Greear wrote:
>>
>> Any idea how this could be done in the stack instead of the driver?
>
> I don't see why it should be?
>
>> The problem is that this is a receiver-side issue, so even if I manage
>> to hack the ath10k firmware or driver rx logic, it would not fix any other
>> IBSS peer connected to ath10k peer.
>>
>
> You mean it's a transmitter-side issue? In that case you should
> probably simply disable aggregation on the broken transmitter ...

Yes, it is a transmitter side problem, and A-MSDU on IBSS
is disabled by default in all ath10k firmware versions that I am aware of.

I was hoping there might be a way to allow A-MSDU + IBSS + ath10k
to work in future kernels without applying out-of-tree
kernel hacks.  This would let people with appropriate firmware
enable IBSS + A-MSDU for added performance in cases where they
knew the peer could support the needed work-around.

I don't think it is worth a lot of effort, but if it were relatively
simple to fix, then maybe it is worth it.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2015-09-30 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 23:00 Can we ignore frames with invalid BSSID in IBSS mode? Ben Greear
2015-09-30  6:46 ` Johannes Berg
2015-09-30 15:07   ` Ben Greear
2015-09-30 15:17     ` Johannes Berg
2015-09-30 15:44       ` Ben Greear
2015-09-30 17:14         ` Johannes Berg
2015-09-30 17:20           ` Ben Greear [this message]
2015-09-30 18:30             ` Johannes Berg
2015-09-30 18:34               ` Ben Greear
2015-09-30 19:04                 ` Felix Fietkau
2015-09-30  8:13 ` Nicolas Cavallari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560C19F3.6070903@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).