From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:64199 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbbJBHps (ORCPT ); Fri, 2 Oct 2015 03:45:48 -0400 Message-ID: <560E3628.4000105@broadcom.com> (sfid-20151002_094559_005891_A69ED075) Date: Fri, 2 Oct 2015 09:45:44 +0200 From: Arend van Spriel MIME-Version: 1.0 To: Chaehyun Lim , CC: , , , , , , , , Dan Carpenter Subject: Re: [PATCH 08/12] staging: wilc1000: use s8 instead of int8_t References: <1443707039-18433-1-git-send-email-chaehyun.lim@gmail.com> <1443707039-18433-8-git-send-email-chaehyun.lim@gmail.com> In-Reply-To: <1443707039-18433-8-git-send-email-chaehyun.lim@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/01/2015 03:43 PM, Chaehyun Lim wrote: > This patch replaces int8_t with s8 that is a preferred type. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > index d781003..56c97c9 100644 > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > @@ -263,9 +263,9 @@ static void clear_duringIP(unsigned long arg) > g_obtainingIP = false; > } > > -int8_t is_network_in_shadow(tstrNetworkInfo *pstrNetworkInfo, void *pUserVoid) > +s8 is_network_in_shadow(tstrNetworkInfo *pstrNetworkInfo, void *pUserVoid) It seems to make more sense to use bool type here. > { > - int8_t state = -1; > + s8 state = -1; You can actually get rid of the state variable. Just replace the statement 'state = i;' by 'return true;' and replace 'return state;' by 'return false;'. > int i; > > if (u32LastScannedNtwrksCountShadow == 0) { > @@ -288,7 +288,7 @@ int8_t is_network_in_shadow(tstrNetworkInfo *pstrNetworkInfo, void *pUserVoid) > > void add_network_to_shadow(tstrNetworkInfo *pstrNetworkInfo, void *pUserVoid, void *pJoinParams) > { > - int8_t ap_found = is_network_in_shadow(pstrNetworkInfo, pUserVoid); > + s8 ap_found = is_network_in_shadow(pstrNetworkInfo, pUserVoid); And here as well. Regards, Arend > u32 ap_index = 0; > u8 rssi_index = 0; > >