From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D708C3A59E for ; Wed, 21 Aug 2019 11:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63437206BB for ; Wed, 21 Aug 2019 11:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbfHUL7Y (ORCPT ); Wed, 21 Aug 2019 07:59:24 -0400 Received: from smtprelay0126.hostedemail.com ([216.40.44.126]:55891 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726749AbfHUL7Y (ORCPT ); Wed, 21 Aug 2019 07:59:24 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 9803D1802B9F8; Wed, 21 Aug 2019 11:59:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bead95_6e7a6e0c32b4a X-Filterd-Recvd-Size: 2118 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Wed, 21 Aug 2019 11:59:19 +0000 (UTC) Message-ID: <5613f082389460cb8de4251c08038c914683bd49.camel@perches.com> Subject: Re: [PATCH v2] mt76: fix some checkpatch warnings From: Joe Perches To: Ryder Lee , Felix Fietkau , Lorenzo Bianconi Cc: Roy Luo , YF Luo , Yiwei Chung , Sean Wang , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 21 Aug 2019 04:59:16 -0700 In-Reply-To: <4ff1174b111ab61e147510ffbcde706d1a00600d.1566356513.git.ryder.lee@mediatek.com> References: <4ff1174b111ab61e147510ffbcde706d1a00600d.1566356513.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2019-08-21 at 11:11 +0800, Ryder Lee wrote: > This fixes the following checkpatch warnings: > CHECK: Alignment should match open parenthesis > CHECK: No space is necessary after a cast > > Signed-off-by: Ryder Lee > --- > Changes since v2: remove false positive checkpatch warnings. What were those? > diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c [] > @@ -587,8 +589,8 @@ mt76_check_sta(struct mt76_dev *dev, struct sk_buff *skb) > } > > if (ieee80211_has_morefrags(hdr->frame_control) || > - !(ieee80211_is_mgmt(hdr->frame_control) || > - ieee80211_is_data(hdr->frame_control))) > + !(ieee80211_is_mgmt(hdr->frame_control) || > + ieee80211_is_data(hdr->frame_control))) Poor alignment here. This should be: if (ieee80211_has_morefrags(hdr->frame_control) || !(ieee80211_is_mgmt(hdr->frame_control) || ieee80211_is_data(hdr->frame_control)))