From: Tony Cho <tony.cho@atmel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com>
Cc: <johnny.kim@atmel.com>, <rachel.kim@atmel.com>,
<chris.park@atmel.com>, <glen.lee@atmel.com>, <leo.kim@atmel.com>,
<linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY
Date: Mon, 12 Oct 2015 11:13:04 +0900 [thread overview]
Message-ID: <561B1730.9050408@atmel.com> (raw)
In-Reply-To: <20151008184724.GA11027@kroah.com>
On 2015년 10월 09일 03:47, Greg KH wrote:
> On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote:
>> Hi!
>>
>> I noticed that drivers/staging/wilc1000/Kconfic defines:
>>
>> config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY
>> bool "Dynamically allocate memory in real time"
>> ---help---
>> This choice supports dynamic allocation of the memory
>> for the receive buffer. The driver will allocate the RX buffer
>> when it is required.
>>
>>
>> "MEMROY" looks suspicious. Is it a typo (MEMORY?) or by intent?
> Probably a typo, but be sure to see if it lines up with what the code
> expects before changing anything.
>
> Ideally in the end this option should be removed as the driver should
> only do dynamic allocation, no static allocation should be needed.
I agree with Greg's opinion. The team is now restructuring the driver and they will be removed and changed.
Thanks for your valuable opinion,
Tony.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2015-10-12 2:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 18:29 staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Stanislav Kholmanskikh
2015-10-08 18:47 ` Greg KH
2015-10-09 18:19 ` [PATCH] staging: wilc1000: typo in WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Stanislav Kholmanskikh
2015-10-09 18:23 ` Dan Carpenter
2015-10-10 12:41 ` [PATCH] staging: wilc1000: remove WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Stanislav Kholmanskikh
2015-10-13 4:05 ` Greg KH
2015-10-12 2:13 ` Tony Cho [this message]
2015-10-12 2:11 ` staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Tony Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561B1730.9050408@atmel.com \
--to=tony.cho@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=kholmanskikh.s.s@gmail.com \
--cc=leo.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).