* [PATCH] staging: wilc1000: restore wilc_spi_dev variable
@ 2015-10-16 20:05 Arnd Bergmann
2015-10-18 9:29 ` Stanislav Kholmanskikh
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-10-16 20:05 UTC (permalink / raw)
To: gregkh
Cc: Stanislav Kholmanskikh, Johnny Kim, Rachel Kim, Chris Park,
Tony Cho, Glen Lee, Leo Kim, linux-wireless, devel, linux-kernel,
linux-arm-kernel
A recent change to wilc1000 accidentally deleted an important
variable, so we now get a build error when the SPI mode is
selected:
ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!
This partially reverts the broken commit to put the variable back.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 56293ff232b9 ("staging: wilc1000: linux_wlan_spi: include header")
---
Found on ARM randconfig builds.
diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wilc1000/linux_wlan_spi.c
index 760b72a9a6ff..039d06192d6b 100644
--- a/drivers/staging/wilc1000/linux_wlan_spi.c
+++ b/drivers/staging/wilc1000/linux_wlan_spi.c
@@ -41,6 +41,7 @@
static u32 SPEED = MIN_SPEED;
+struct spi_device *wilc_spi_dev;
void linux_spi_deinit(void *vp);
static int __init wilc_bus_probe(struct spi_device *spi)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wilc1000: restore wilc_spi_dev variable
2015-10-16 20:05 [PATCH] staging: wilc1000: restore wilc_spi_dev variable Arnd Bergmann
@ 2015-10-18 9:29 ` Stanislav Kholmanskikh
0 siblings, 0 replies; 2+ messages in thread
From: Stanislav Kholmanskikh @ 2015-10-18 9:29 UTC (permalink / raw)
To: Arnd Bergmann, gregkh
Cc: Johnny Kim, Rachel Kim, Chris Park, Tony Cho, Glen Lee, Leo Kim,
linux-wireless, devel, linux-kernel, linux-arm-kernel
Hi!
On 16.10.2015 23:05, Arnd Bergmann wrote:
> A recent change to wilc1000 accidentally deleted an important
> variable, so we now get a build error when the SPI mode is
> selected:
>
> ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!
>
> This partially reverts the broken commit to put the variable back.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 56293ff232b9 ("staging: wilc1000: linux_wlan_spi: include header")
> ---
I'm really sorry about it, will be more careful in the future.
Thank you for fixing this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-18 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 20:05 [PATCH] staging: wilc1000: restore wilc_spi_dev variable Arnd Bergmann
2015-10-18 9:29 ` Stanislav Kholmanskikh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).