From: Felix Fietkau <nbd@openwrt.org>
To: Dmitry Ivanov <dmitrijs.ivanovs@ubnt.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Minstrel_ht: use lowest rate last
Date: Wed, 28 Oct 2015 11:22:52 +0100 [thread overview]
Message-ID: <5630A1FC.6010309@openwrt.org> (raw)
In-Reply-To: <20151026114236.233d1b54e6c08f3ab2b4c41a@ubnt.com>
On 2015-10-26 10:42, Dmitry Ivanov wrote:
> Minstrel_ht: use lowest rate last as in minstrel.
> It should improve robustness in environments with non-stationary noise.
>
> Signed-off-by: Dmitry Ivanov <dima@ubnt.com>
Not using the lowest rate is intentional. Using the lowest rate severely
limits aggregation. In many cases, dropping a packet is preferrable, as
trying too hard to retry individual packets can cause extra bufferbloat
and severely increased latencies.
NACK from me on this patch. If anything, I think we should probably
change minstrel to behave in the same way as minstrel_ht.
- Felix
prev parent reply other threads:[~2015-10-28 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 9:42 [PATCH] Minstrel_ht: use lowest rate last Dmitry Ivanov
2015-10-28 10:22 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5630A1FC.6010309@openwrt.org \
--to=nbd@openwrt.org \
--cc=dmitrijs.ivanovs@ubnt.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).