linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] realtek: rtlwifi: rtl8821ae: Fix lockups on boot
Date: Thu, 12 Nov 2015 15:29:19 -0600	[thread overview]
Message-ID: <564504AF.5030201@lwfinger.net> (raw)
In-Reply-To: <87a8qj56yz.fsf@kamboji.qca.qualcomm.com>

On 11/12/2015 01:54 PM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> In commit 54328e64047a5 ("rtlwifi: rtl8821ae: Fix system lockups on boot"),
>> an attempt was made to fix a regression introduced in commit 1277fa2ab2f9
>> ("rtlwifi: Remove the clear interrupt routine from all drivers").
>> Unfortunately, there were logic errors in that patch that prevented
>> affected boxes from booting even after that patch was applied.
>>
>> The actual cause of the original problem is unknown as none of the
>> developers have systems that are affected.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org> [V4.1+]
>
> I think the "realtek:" prefix is superfluous, "rtlwifi:" should be
> enough. I'll also add a fixes line before I commit this:
>
> Fixes: 54328e64047a ("rtlwifi: rtl8821ae: Fix system lockups on boot")

I'll drop the extra prefix in the future. Your extra line is good.

Larry



  reply	other threads:[~2015-11-12 21:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 16:46 [PATCH] realtek: rtlwifi: rtl8821ae: Fix lockups on boot Larry Finger
2015-11-12 19:54 ` Kalle Valo
2015-11-12 21:29   ` Larry Finger [this message]
2015-11-17 13:59 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564504AF.5030201@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).