Re: [PATCH 6/9] brcmfmac: Add RSDB support.

[Arend van Spriel <arend@broadcom.com>]

On 11/12/2015 08:49 PM, Kalle Valo wrote:
> Arend van Spriel <arend@broadcom.com> writes:
>
>> From: Hante Meuleman <meuleman@broadcom.com>
>>
>> RSDB works almost autonomously in firmware except for AP config.
>> When device supports RSDB then the interface should not be
>> brought down when configuring it, otherwise the link (if
>> configured) on the other interface will be lost.
>>
>> Reviewed-by: Arend Van Spriel <arend@broadcom.com>
>> Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
>> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>
> I have never heard of acronym RSDB before and after some googling I
> think it might mean Real Simultaneous Dual Band. But please try to avoid
> using acronyms and clearly spell it out in the commit log what the
> feature is about.

Google is correct and the acronym is cooked up by Broadcom ;-) In the 
cover letter I mentioned:

* support bcm4359 which can operate in two bands concurrently.

which is a device with two 802.11 cores and hence supports RSDB.

> If you send me suggestions what to add I can edit the commit log before
> I apply this patch.

If needed I can resubmit the patch. This would be the proposed commit log:

Broadcom devices with a single 802.11 core can work on two band
concurrently using VSDB feature, ie. Virtual Simultaneous Dual-Band.
For devices that are fitted with two 802.11 cores and RF paths the
driver should support a firmware feature called RSDB, which stands
for Real Simultaneous Dual-Band. RSDB works almost autonomously in 
firmware except for AP config. When the device supports RSDB then
the interface should not be brought down when configuring it,
otherwise the link (if configured) on the other interface will be
lost.

Hope this helps and let me know if other actions are required from us.

Regards,
Arend