From: Robert Baldyga <r.baldyga@samsung.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-nfc@lists.01.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures
Date: Fri, 13 Nov 2015 15:28:32 +0100 [thread overview]
Message-ID: <5645F390.9040407@samsung.com> (raw)
In-Reply-To: <1447416281-3357-1-git-send-email-Julia.Lawall@lip6.fr>
On 11/13/2015 01:04 PM, Julia Lawall wrote:
> The s3fwrn5_phy_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Robert Baldyga <r.baldyga@samsung.com>
Thanks!
Robert Baldyga
>
> ---
> drivers/nfc/s3fwrn5/core.c | 2 +-
> drivers/nfc/s3fwrn5/i2c.c | 2 +-
> drivers/nfc/s3fwrn5/s3fwrn5.h | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nfc/s3fwrn5/core.c b/drivers/nfc/s3fwrn5/core.c
> index 0d866ca..9d9c8d5 100644
> --- a/drivers/nfc/s3fwrn5/core.c
> +++ b/drivers/nfc/s3fwrn5/core.c
> @@ -147,7 +147,7 @@ static struct nci_ops s3fwrn5_nci_ops = {
> };
>
> int s3fwrn5_probe(struct nci_dev **ndev, void *phy_id, struct device *pdev,
> - struct s3fwrn5_phy_ops *phy_ops, unsigned int max_payload)
> + const struct s3fwrn5_phy_ops *phy_ops, unsigned int max_payload)
> {
> struct s3fwrn5_info *info;
> int ret;
> diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c
> index c61d8a3..3ed0adf 100644
> --- a/drivers/nfc/s3fwrn5/i2c.c
> +++ b/drivers/nfc/s3fwrn5/i2c.c
> @@ -125,7 +125,7 @@ static int s3fwrn5_i2c_write(void *phy_id, struct sk_buff *skb)
> return 0;
> }
>
> -static struct s3fwrn5_phy_ops i2c_phy_ops = {
> +static const struct s3fwrn5_phy_ops i2c_phy_ops = {
> .set_wake = s3fwrn5_i2c_set_wake,
> .set_mode = s3fwrn5_i2c_set_mode,
> .get_mode = s3fwrn5_i2c_get_mode,
> diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h
> index 89210d4..7d5e516 100644
> --- a/drivers/nfc/s3fwrn5/s3fwrn5.h
> +++ b/drivers/nfc/s3fwrn5/s3fwrn5.h
> @@ -44,7 +44,7 @@ struct s3fwrn5_info {
> void *phy_id;
> struct device *pdev;
>
> - struct s3fwrn5_phy_ops *phy_ops;
> + const struct s3fwrn5_phy_ops *phy_ops;
> unsigned int max_payload;
>
> struct s3fwrn5_fw_info fw_info;
> @@ -90,7 +90,7 @@ static inline int s3fwrn5_write(struct s3fwrn5_info *info, struct sk_buff *skb)
> }
>
> int s3fwrn5_probe(struct nci_dev **ndev, void *phy_id, struct device *pdev,
> - struct s3fwrn5_phy_ops *phy_ops, unsigned int max_payload);
> + const struct s3fwrn5_phy_ops *phy_ops, unsigned int max_payload);
> void s3fwrn5_remove(struct nci_dev *ndev);
>
> int s3fwrn5_recv_frame(struct nci_dev *ndev, struct sk_buff *skb,
>
>
next prev parent reply other threads:[~2015-11-13 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 12:04 [PATCH] nfc: s3fwrn5: constify s3fwrn5_phy_ops structures Julia Lawall
2015-11-13 14:28 ` Robert Baldyga [this message]
2015-12-20 17:51 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645F390.9040407@samsung.com \
--to=r.baldyga@samsung.com \
--cc=Julia.Lawall@lip6.fr \
--cc=aloisio.almeida@openbossa.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).