From: Antonio Quartulli <antonio@open-mesh.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH v2 2/2] mac80211: passively scan DFS channels if requested
Date: Fri, 20 Nov 2015 20:52:32 +0800 [thread overview]
Message-ID: <564F1790.7030309@open-mesh.com> (raw)
In-Reply-To: <1448016547.3141.4.camel@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On 20/11/15 18:49, Johannes Berg wrote:
>
>> @@ -599,7 +599,9 @@ static int __ieee80211_start_scan(struct
>> ieee80211_sub_if_data *sdata,
>>
>> if ((req->channels[0]->flags &
>> IEEE80211_CHAN_NO_IR) ||
>> - !req->n_ssids) {
>> + !req->n_ssids ||
>> + ((req->channels[0]->flags &
>> IEEE80211_CHAN_RADAR) &&
>> + (req->flags &
>> NL80211_SCAN_FLAG_PASSIVE_RADAR))) {
>> next_delay = IEEE80211_PASSIVE_CHANNEL_TIME;
>>
>
> I don't really see any circumstances under which it's valid to actively
> scan radar channels ... seems like we should do this unconditionally?
I think it would be reasonable only if the target channel is the one we
are using and we have done CSA. But when scanning non-operative channels
I don't think this could work.
As discussed on IRC I'd rather go for passively scanning any DFS channel.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-20 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 1:29 [PATCH v2 1/2] nl80211: add flag to force passive scan on DFS channels Antonio Quartulli
2015-11-14 1:29 ` [PATCH v2 2/2] mac80211: passively scan DFS channels if requested Antonio Quartulli
2015-11-20 10:49 ` Johannes Berg
2015-11-20 12:52 ` Antonio Quartulli [this message]
2016-10-24 12:11 ` Antonio Quartulli
2016-10-24 13:33 ` Johannes Berg
2016-10-24 13:35 ` Antonio Quartulli
2016-10-24 13:42 ` Simon Wunderlich
2016-10-24 14:07 ` Michal Kazior
2016-10-24 14:16 ` Johannes Berg
2016-10-24 14:36 ` Simon Wunderlich
2016-10-24 14:38 ` Johannes Berg
2016-10-24 14:53 ` Simon Wunderlich
2016-10-26 12:58 ` Johannes Berg
2016-10-26 13:30 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564F1790.7030309@open-mesh.com \
--to=antonio@open-mesh.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).