linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Can we increase IEEE80211_MAX_QUEUES
Date: Thu, 3 Dec 2015 12:29:23 -0800	[thread overview]
Message-ID: <5660A623.1040002@candelatech.com> (raw)
In-Reply-To: <1449174081.31265.3.camel@sipsolutions.net>

On 12/03/2015 12:21 PM, Johannes Berg wrote:
> On Thu, 2015-12-03 at 12:16 -0800, Ben Greear wrote:
>> ath10k wants to use vdev-id as a queue-id, and I want to support up
>> to
>> 64 vdevs.  In the 4.2 kernel, this is causing splats when using lots
>> of
>> vdevs because then queue is out of range.
>>
>> Can we just increase IEEE80211_MAX_QUEUES to 64?
>>
>
> I think not, that would likely cause a lot of data structures to grow
> too much. We'd have to do more dynamic things in that case, I suppose.
>
> Does the original premise even make sense though? A single queue for
> each vdev seems a bit strange.

I think it is all fakery in the driver, but I'm not sure how easy it
would be to fix.

I'm not certain why I'm suddenly seeing this, but I just started using 4.2 kernel
again and maybe that is the difference.  I also tweaked firmware recently...

I'll make a stab at allowing 64 queues, and also try to figure out why
I started seeing the problem.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  parent reply	other threads:[~2015-12-03 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 20:16 Can we increase IEEE80211_MAX_QUEUES Ben Greear
2015-12-03 20:21 ` Johannes Berg
2015-12-03 20:24   ` Johannes Berg
2015-12-03 20:29   ` Ben Greear [this message]
2015-12-03 23:12   ` Ben Greear
2015-12-05 13:22     ` Michal Kazior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5660A623.1040002@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).