From: Simon Malthieu <simon.malthieu@luceor.com>
To: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: ath10k and mac80211 number of chains meaning
Date: Fri, 11 Dec 2015 10:04:06 +0100 [thread overview]
Message-ID: <566A9186.6020807@luceor.com> (raw)
Hi,
I would like to know the exact meaning of "chains" member of struct
sta_info. mac80211 sta_info.h states :
"@chains: chains ever used for RX from this station"
In ath9k, it is incremented when testing each value of the chain_signal
array (code here is ath9k common.c) :
if (rssi != ATH9K_RSSI_BAD) {
rxs->chains |= BIT(j);
rxs->chain_signal[j] = ah->noise + rssi;
}
I did this in ath10k (htt-rx.c l.874) on the model of a patch published
on the mailing list :
static void ath10k_htt_rx_h_signal(struct ath10k *ar,
struct ieee80211_rx_status *status,
struct htt_rx_desc *rxd)
{
u8 signal_per_chain;
int i;
for (i = 0; i< IEEE80211_MAX_CHAINS; i++)
{
signal_per_chain = rxd->ppdu_start.rssi_chains[i].pri20_mhz;
if (signal_per_chain != ATH10K_RSSI_BAD) // = 0x80
{
status->chains |= BIT(i);
status->chain_signal[i] = ATH10K_DEFAULT_NOISE_FLOOR +
signal_per_chain;
}
}
/* FIXME: Get real NF */
status->signal = ATH10K_DEFAULT_NOISE_FLOOR +
rxd->ppdu_start.rssi_comb;
status->flag &= ~RX_FLAG_NO_SIGNAL_VAL;
}
But when I configure the number of antennas (iw phy0 set antennas - iw
3.15) lower than the maximum of antennas, chains doesn't change, i.e.
there is still a correct value in chain_signal of the disabled antennas
(the value is not updated though).
I don't understand how a signal value can be received from a STA if the
antennas configuration doesn't allow it.
If it is not a bug, should i check rx_chain_mask in the driver to verify
the antennas configuration instead of chains ?
Thanks for your help
Simon
reply other threads:[~2015-12-11 9:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566A9186.6020807@luceor.com \
--to=simon.malthieu@luceor.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).