From: Peter Oh <poh@codeaurora.org>
To: Felix Fietkau <nbd@openwrt.org>, Peter Oh <poh@qca.qualcomm.com>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable
Date: Wed, 16 Dec 2015 12:29:14 -0800 [thread overview]
Message-ID: <5671C99A.703@codeaurora.org> (raw)
In-Reply-To: <5671AD10.70004@openwrt.org>
On 12/16/2015 10:27 AM, Felix Fietkau wrote:
> On 2015-12-16 19:20, Peter Oh wrote:
>> Some hardwares such as QCA988X and QCA99X0 doesn't have
>> capability of checksum offload when frame formats are not
>> suitable for it such as Mesh frame.
>> Hence add a module parameter, hw_csum, to make checksum offload
>> configurable during module registration time.
>>
>> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
> How about instead of inventing yet another crappy module parameter, you
> call skb_checksum_help() in the driver in cases where the hardware is
> unable to offload the checksum calculation.
>
> That way the user has to worry about less driver specific hackery ;)
That will be good option for hardware not supporting HW checksum, but I
mind that using the function will add more workload per every packet on
critical data path when HW supports checksum resulting in throughput down.
> - Felix
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
Peter
next prev parent reply other threads:[~2015-12-16 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 18:20 [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable Peter Oh
2015-12-16 18:27 ` Felix Fietkau
2015-12-16 20:29 ` Peter Oh [this message]
2015-12-16 20:35 ` Felix Fietkau
2015-12-16 20:46 ` Peter Oh
2015-12-16 20:53 ` Felix Fietkau
2015-12-16 21:19 ` Peter Oh
2015-12-16 21:54 ` Felix Fietkau
2015-12-16 23:50 ` Peter Oh
2015-12-16 23:59 ` Felix Fietkau
2015-12-17 22:01 ` Peter Oh
2015-12-17 22:57 ` Felix Fietkau
2015-12-17 23:16 ` Peter Oh
2015-12-17 7:29 ` Michal Kazior
2015-12-17 21:55 ` Peter Oh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5671C99A.703@codeaurora.org \
--to=poh@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=poh@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).