Re: [Bug 110551] iwlwifi: dvm: cannot turn off wifi LED

[Hubert Tarasiuk <hubert.tarasiuk@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 492 bytes --]

Attached is the patch for bug 110551.

W dniu 24.01.2016 o 11:16, bugzilla-daemon@bugzilla.kernel.org pisze:
> https://bugzilla.kernel.org/show_bug.cgi?id=110551
> 
> --- Comment #13 from Emmanuel Grumbach <emmanuel.grumbach@intel.com> ---
> https://bugzilla.kernel.org/attachment.cgi?id=201271
> 
> This one seems to have a fix for the module param as well.
> I would much prefer you to send the patch to the wireless mailing list rather
> than attaching it to this bugzilla.
> 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-iwlwifi-dvm-handle-zero-brightness-for-wifi-LED.patch --]
[-- Type: text/x-patch; name="0001-iwlwifi-dvm-handle-zero-brightness-for-wifi-LED.patch", Size: 1290 bytes --]

From 40e783a5464e43722d87b5cb0c3d3899f3f7417e Mon Sep 17 00:00:00 2001
From: Hubert Tarasiuk <hubert.tarasiuk@gmail.com>
Date: Mon, 4 Jan 2016 23:45:18 +0100
Subject: [PATCH] iwlwifi: dvm: handle zero brightness for wifi LED

This fixes bug 110551 with regard to sysfs.

Misleading behaviour when 'led_mode=3' is passed to iwlwifi is still
to be fixed (either by changing the option description or by making
the LED permanently dark in such case).

Signed-off-by: Hubert Tarasiuk <hubert.tarasiuk@gmail.com>
---
 drivers/net/wireless/iwlwifi/dvm/led.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlwifi/dvm/led.c b/drivers/net/wireless/iwlwifi/dvm/led.c
index ca4d669..218617a 100644
--- a/drivers/net/wireless/iwlwifi/dvm/led.c
+++ b/drivers/net/wireless/iwlwifi/dvm/led.c
@@ -154,11 +154,14 @@ static void iwl_led_brightness_set(struct led_classdev *led_cdev,
 {
 	struct iwl_priv *priv = container_of(led_cdev, struct iwl_priv, led);
 	unsigned long on = 0;
+	unsigned long off = 0;
 
 	if (brightness > 0)
 		on = IWL_LED_SOLID;
+	else
+		off = IWL_LED_SOLID;
 
-	iwl_led_cmd(priv, on, 0);
+	iwl_led_cmd(priv, on, off);
 }
 
 static int iwl_led_blink_set(struct led_classdev *led_cdev,
-- 
2.7.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]