From: Peter Oh <poh@codeaurora.org>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 13/13] ath10k: implement push-pull tx
Date: Tue, 26 Jan 2016 11:03:09 -0800 [thread overview]
Message-ID: <56A7C2ED.4010809@codeaurora.org> (raw)
In-Reply-To: <CA+BoTQ=ujALZiD5njhd=4e6iASJpxUeL7Kh_Pe_1zbAe9hLYcw@mail.gmail.com>
On 01/26/2016 02:28 AM, Michal Kazior wrote:
> On 22 January 2016 at 08:47, Michal Kazior <michal.kazior@tieto.com> wrote:
>> On 21 January 2016 at 18:40, Peter Oh <poh@codeaurora.org> wrote:
>>> On 01/21/2016 05:46 AM, Michal Kazior wrote:
> [...]
>>>> - /* TODO: apply configuration */
>>>> + rcu_read_unlock();
>>>> +
>>>> + spin_lock_bh(&ar->htt.tx_lock);
>>>> + ath10k_mac_tx_lock(ar, ATH10K_TX_PAUSE_Q_FLUSH_PENDING);
>>>> + spin_unlock_bh(&ar->htt.tx_lock);
>>>> +
>>> Isn't it proved it break Mesh from working?
>> Yes, good point. I'm still working on this - I should've mentioned
>> that in the cover letter.
>>
>> Nonetheless I wanted to get the review process going for this patchset.
>>
>> I'll address the mesh problem in v2.
> For the record - the problem turned out to be a bug in mac80211 mesh
> fwding, see:
>
> https://patchwork.kernel.org/patch/8108711/
I've verified that the patch fixed the mesh issue.
Thank you Michal.
>
>
> Michał
next prev parent reply other threads:[~2016-01-26 19:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 13:46 [PATCH 00/13] ath10k: implement push-pull tx model Michal Kazior
2016-01-21 13:46 ` [PATCH 01/13] ath10k: refactor tx code Michal Kazior
2016-01-21 13:46 ` [PATCH 02/13] ath10k: unify txpath decision Michal Kazior
2016-01-21 13:46 ` [PATCH 03/13] ath10k: refactor tx pending management Michal Kazior
2016-01-21 13:46 ` [PATCH 04/13] ath10k: maintain peer_id for each sta and vif Michal Kazior
2016-01-21 13:46 ` [PATCH 05/13] ath10k: add fast peer_map lookup Michal Kazior
2016-01-21 13:46 ` [PATCH 06/13] ath10k: add new htt message generation/parsing logic Michal Kazior
2016-01-21 13:46 ` [PATCH 07/13] ath10k: implement wake_tx_queue Michal Kazior
2016-01-21 13:46 ` [PATCH 08/13] ath10k: implement updating shared htt txq state Michal Kazior
2016-01-21 13:46 ` [PATCH 09/13] ath10k: add txq placeholder Michal Kazior
2016-01-21 13:46 ` [PATCH 10/13] ath10k: implement flushing of pending frames in txqs Michal Kazior
2016-03-04 9:17 ` Valo, Kalle
2016-03-04 9:52 ` Michal Kazior
2016-03-04 15:37 ` Valo, Kalle
2016-01-21 13:46 ` [PATCH 11/13] ath10k: store txq in skb_cb Michal Kazior
2016-01-21 13:46 ` [PATCH 12/13] ath10k: keep track of queue depth per txq Michal Kazior
2016-01-21 13:46 ` [PATCH 13/13] ath10k: implement push-pull tx Michal Kazior
2016-01-21 17:40 ` Peter Oh
2016-01-22 7:47 ` Michal Kazior
2016-01-26 10:28 ` Michal Kazior
2016-01-26 19:03 ` Peter Oh [this message]
2016-01-28 8:36 ` Kalle Valo
2016-01-22 0:43 ` [PATCH 00/13] ath10k: implement push-pull tx model Ben Greear
2016-03-01 10:32 ` [PATCH v2 00/11] " Michal Kazior
2016-03-01 10:32 ` [PATCH v2 01/11] ath10k: refactor tx code Michal Kazior
2016-03-01 10:32 ` [PATCH v2 02/11] ath10k: unify txpath decision Michal Kazior
2016-03-01 10:32 ` [PATCH v2 03/11] ath10k: refactor tx pending management Michal Kazior
2016-03-01 10:32 ` [PATCH v2 04/11] ath10k: maintain peer_id for each sta and vif Michal Kazior
2016-03-01 10:32 ` [PATCH v2 05/11] ath10k: add fast peer_map lookup Michal Kazior
2016-03-01 10:32 ` [PATCH v2 06/11] ath10k: add new htt message generation/parsing logic Michal Kazior
2016-03-01 10:32 ` [PATCH v2 07/11] ath10k: implement wake_tx_queue Michal Kazior
2016-03-06 14:27 ` Valo, Kalle
2016-03-07 6:04 ` Michal Kazior
2016-03-07 9:36 ` Valo, Kalle
2016-03-01 10:32 ` [PATCH v2 08/11] ath10k: implement updating shared htt txq state Michal Kazior
2016-03-01 10:32 ` [PATCH v2 09/11] ath10k: store txq in skb_cb Michal Kazior
2016-03-01 10:32 ` [PATCH v2 10/11] ath10k: keep track of queue depth per txq Michal Kazior
2016-03-01 10:32 ` [PATCH v2 11/11] ath10k: implement push-pull tx Michal Kazior
2016-03-06 14:18 ` [PATCH v2 00/11] ath10k: implement push-pull tx model Valo, Kalle
2016-03-07 6:13 ` Michal Kazior
2016-03-07 9:48 ` Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A7C2ED.4010809@codeaurora.org \
--to=poh@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).