[PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Javier Martinez Canillas]

This driver only has a runtime but no build time dependencies so can be
built for testing purposes if the Kconfig COMPILE_TEST option is enabled.

This is useful to have more build coverage and make sure that the driver
is not affected by changes that could cause a build regression.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/bcma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index 023d448ed3fa..22114995dfbf 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -63,7 +63,7 @@ config BCMA_DRIVER_PCI_HOSTMODE
 
 config BCMA_DRIVER_MIPS
 	bool "BCMA Broadcom MIPS core driver"
-	depends on BCMA && MIPS
+	depends on BCMA && (MIPS || COMPILE_TEST)
 	help
 	  Driver for the Broadcom MIPS core attached to Broadcom specific
 	  Advanced Microcontroller Bus.
-- 
2.4.3

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2921 bytes --]

Hi Javier,

[auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Javier-Martinez-Canillas/bcma-mips-Allow-build-if-COMPILE_TEST-is-enabled/20151013-214630
config: i386-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_read':
>> drivers/mtd/devices/bcm47xxsflash.c:112:37: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration]
     memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from),
                                        ^
   cc1: some warnings being treated as errors

vim +/KSEG0ADDR +112 drivers/mtd/devices/bcm47xxsflash.c

c0fcbc56 Rafał Miłecki  2013-05-21   96  
c0fcbc56 Rafał Miłecki  2013-05-21   97  	if (erase->callback)
c0fcbc56 Rafał Miłecki  2013-05-21   98  		erase->callback(erase);
c0fcbc56 Rafał Miłecki  2013-05-21   99  
c0fcbc56 Rafał Miłecki  2013-05-21  100  	return err;
c0fcbc56 Rafał Miłecki  2013-05-21  101  }
c0fcbc56 Rafał Miłecki  2013-05-21  102  
5fe42d5b Rafał Miłecki  2012-09-17  103  static int bcm47xxsflash_read(struct mtd_info *mtd, loff_t from, size_t len,
5fe42d5b Rafał Miłecki  2012-09-17  104  			      size_t *retlen, u_char *buf)
5fe42d5b Rafał Miłecki  2012-09-17  105  {
a2f74a7d Rafał Miłecki  2013-01-06  106  	struct bcm47xxsflash *b47s = mtd->priv;
5fe42d5b Rafał Miłecki  2012-09-17  107  
5fe42d5b Rafał Miłecki  2012-09-17  108  	/* Check address range */
5fe42d5b Rafał Miłecki  2012-09-17  109  	if ((from + len) > mtd->size)
5fe42d5b Rafał Miłecki  2012-09-17  110  		return -EINVAL;
5fe42d5b Rafał Miłecki  2012-09-17  111  
a2f74a7d Rafał Miłecki  2013-01-06 @112  	memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from),
5fe42d5b Rafał Miłecki  2012-09-17  113  		      len);
60aca067 Hauke Mehrtens 2013-01-24  114  	*retlen = len;
5fe42d5b Rafał Miłecki  2012-09-17  115  
5fe42d5b Rafał Miłecki  2012-09-17  116  	return len;
5fe42d5b Rafał Miłecki  2012-09-17  117  }
5fe42d5b Rafał Miłecki  2012-09-17  118  
13134f48 Rafał Miłecki  2013-05-22  119  static int bcm47xxsflash_write_st(struct mtd_info *mtd, u32 offset, size_t len,
13134f48 Rafał Miłecki  2013-05-22  120  				  const u_char *buf)

:::::: The code at line 112 was first introduced by commit
:::::: a2f74a7dacc1c17a0b146eb3112217874c5db436 mtd: bcm47xxsflash: add own struct for abstrating bus type

:::::: TO: Rafał Miłecki <zajec5@gmail.com>
:::::: CC: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 51617 bytes --]

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Javier Martinez Canillas]

Hello,

On 10/13/2015 05:25 PM, kbuild test robot wrote:
> Hi Javier,
> 
> [auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
> 
> url:    https://github.com/0day-ci/linux/commits/Javier-Martinez-Canillas/bcma-mips-Allow-build-if-COMPILE_TEST-is-enabled/20151013-214630
> config: i386-allmodconfig (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_read':
>>> drivers/mtd/devices/bcm47xxsflash.c:112:37: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration]
>      memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from),
>                    

Thanks for reporting this issue. I only did a partial build with
make M=drivers/bcma but didn't think about implicit dependencies
on other drivers.

I've posted this patch that should avoid this issue:
https://patchwork.kernel.org/patch/7391551/

BTW, 0-day bot used to reports from email address fengguang.wu@intel.com
but now reports from lkp@intel.com. I still added a Reported-by tag from
Fengguang Wu <fengguang.wu@intel.com> but I wonder if I should change it
to kbuild test robot <lkp@intel.com> for future patches?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [kbuild-all] [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Fengguang Wu]

Hi Javier,

> BTW, 0-day bot used to reports from email address fengguang.wu@intel.com
> but now reports from lkp@intel.com. I still added a Reported-by tag from
> Fengguang Wu <fengguang.wu@intel.com> but I wonder if I should change it
> to kbuild test robot <lkp@intel.com> for future patches?

Either is fine. lkp is my lab account. I have to use it when replying
to mailing list emails because my account does not subscribe to so many
lists.

Thanks,
Fengguang

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Kalle Valo]

Javier Martinez Canillas <javier@osg.samsung.com> writes:

> Hello,
>
> On 10/13/2015 05:25 PM, kbuild test robot wrote:
>> Hi Javier,
>> 
>> [auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>> 
>> url:    https://github.com/0day-ci/linux/commits/Javier-Martinez-Canillas/bcma-mips-Allow-build-if-COMPILE_TEST-is-enabled/20151013-214630
>> config: i386-allmodconfig (attached as .config)
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=i386 
>> 
>> All errors (new ones prefixed by >>):
>> 
>>    drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_read':
>>>> drivers/mtd/devices/bcm47xxsflash.c:112:37: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration]
>>      memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from),
>>                    
>
> Thanks for reporting this issue. I only did a partial build with
> make M=drivers/bcma but didn't think about implicit dependencies
> on other drivers.
>
> I've posted this patch that should avoid this issue:
> https://patchwork.kernel.org/patch/7391551/

So this patch ("bcma: mips: Allow build if COMPILE_TEST is enabled")
depend on that patch ("mtd: Make MTD_BCM47XXSFLASH to depend on MIPS"),
right? So I cannot apply the bcma patch until the mtd patch is in my
tree.

-- 
Kalle Valo

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Javier Martinez Canillas]

Hello Kalle,

On 10/14/2015 12:52 PM, Kalle Valo wrote:
> Javier Martinez Canillas <javier@osg.samsung.com> writes:
> 
>> Hello,
>>
>> On 10/13/2015 05:25 PM, kbuild test robot wrote:
>>> Hi Javier,
>>>
>>> [auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/Javier-Martinez-Canillas/bcma-mips-Allow-build-if-COMPILE_TEST-is-enabled/20151013-214630
>>> config: i386-allmodconfig (attached as .config)
>>> reproduce:
>>>         # save the attached .config to linux build tree
>>>         make ARCH=i386 
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    drivers/mtd/devices/bcm47xxsflash.c: In function 'bcm47xxsflash_read':
>>>>> drivers/mtd/devices/bcm47xxsflash.c:112:37: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration]
>>>      memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from),
>>>                    
>>
>> Thanks for reporting this issue. I only did a partial build with
>> make M=drivers/bcma but didn't think about implicit dependencies
>> on other drivers.
>>
>> I've posted this patch that should avoid this issue:
>> https://patchwork.kernel.org/patch/7391551/
> 
> So this patch ("bcma: mips: Allow build if COMPILE_TEST is enabled")
> depend on that patch ("mtd: Make MTD_BCM47XXSFLASH to depend on MIPS"),
> right? So I cannot apply the bcma patch until the mtd patch is in my
> tree.
>

That's correct, sorry for not stating it explicitly.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Kalle Valo]

Javier Martinez Canillas <javier@osg.samsung.com> writes:

> On 10/14/2015 12:52 PM, Kalle Valo wrote:
>> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>> 
>>> Thanks for reporting this issue. I only did a partial build with
>>> make M=drivers/bcma but didn't think about implicit dependencies
>>> on other drivers.
>>>
>>> I've posted this patch that should avoid this issue:
>>> https://patchwork.kernel.org/patch/7391551/
>> 
>> So this patch ("bcma: mips: Allow build if COMPILE_TEST is enabled")
>> depend on that patch ("mtd: Make MTD_BCM47XXSFLASH to depend on MIPS"),
>> right? So I cannot apply the bcma patch until the mtd patch is in my
>> tree.
>
> That's correct, sorry for not stating it explicitly.

Ok, I put the patch now to "Awaiting Upstream" state in patchwork and
will apply it once I have the mtd patch.

-- 
Kalle Valo

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Javier Martinez Canillas]

Hello Kale,

On 10/14/2015 01:04 PM, Kalle Valo wrote:
> Javier Martinez Canillas <javier@osg.samsung.com> writes:
> 
>> On 10/14/2015 12:52 PM, Kalle Valo wrote:
>>> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>>>
>>>> Thanks for reporting this issue. I only did a partial build with
>>>> make M=drivers/bcma but didn't think about implicit dependencies
>>>> on other drivers.
>>>>
>>>> I've posted this patch that should avoid this issue:
>>>> https://patchwork.kernel.org/patch/7391551/
>>>
>>> So this patch ("bcma: mips: Allow build if COMPILE_TEST is enabled")
>>> depend on that patch ("mtd: Make MTD_BCM47XXSFLASH to depend on MIPS"),
>>> right? So I cannot apply the bcma patch until the mtd patch is in my
>>> tree.
>>
>> That's correct, sorry for not stating it explicitly.
> 
> Ok, I put the patch now to "Awaiting Upstream" state in patchwork and
> will apply it once I have the mtd patch.
>

Great, thanks a lot for your help!
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Kalle Valo]

Kalle Valo <kvalo@codeaurora.org> writes:

> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>
>> On 10/14/2015 12:52 PM, Kalle Valo wrote:
>>> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>>> 
>>>> Thanks for reporting this issue. I only did a partial build with
>>>> make M=drivers/bcma but didn't think about implicit dependencies
>>>> on other drivers.
>>>>
>>>> I've posted this patch that should avoid this issue:
>>>> https://patchwork.kernel.org/patch/7391551/
>>> 
>>> So this patch ("bcma: mips: Allow build if COMPILE_TEST is enabled")
>>> depend on that patch ("mtd: Make MTD_BCM47XXSFLASH to depend on MIPS"),
>>> right? So I cannot apply the bcma patch until the mtd patch is in my
>>> tree.
>>
>> That's correct, sorry for not stating it explicitly.
>
> Ok, I put the patch now to "Awaiting Upstream" state in patchwork and
> will apply it once I have the mtd patch.

I don't see "mtd: Make MTD_BCM47XXSFLASH to depend on MIPS" in 4.4-rc1.
I'll drop this now, please resend once the dependency patch is applied.

-- 
Kalle Valo

Re: [PATCH] bcma: mips: Allow build if COMPILE_TEST is enabled

[Javier Martinez Canillas]

Hello Kalle,

On 01/28/2016 10:05 AM, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>>
>>> On 10/14/2015 12:52 PM, Kalle Valo wrote:
>>>> Javier Martinez Canillas <javier@osg.samsung.com> writes:
>>>>
>>>>> Thanks for reporting this issue. I only did a partial build with
>>>>> make M=drivers/bcma but didn't think about implicit dependencies
>>>>> on other drivers.
>>>>>
>>>>> I've posted this patch that should avoid this issue:
>>>>> https://patchwork.kernel.org/patch/7391551/
>>>>
>>>> So this patch ("bcma: mips: Allow build if COMPILE_TEST is enabled")
>>>> depend on that patch ("mtd: Make MTD_BCM47XXSFLASH to depend on MIPS"),
>>>> right? So I cannot apply the bcma patch until the mtd patch is in my
>>>> tree.
>>>
>>> That's correct, sorry for not stating it explicitly.
>>
>> Ok, I put the patch now to "Awaiting Upstream" state in patchwork and
>> will apply it once I have the mtd patch.
>
> I don't see "mtd: Make MTD_BCM47XXSFLASH to depend on MIPS" in 4.4-rc1.

Yeah, my patch started a very long discussion which has become too MIPS
specific for me to follow. The latest email from January 24 is [0].

> I'll drop this now, please resend once the dependency patch is applied.
>

Yeah, just drop the patch and I can resend if/when the discussion of the
first patch settles and someone fix it properly.

[0]: https://lkml.org/lkml/2016/1/24/320

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America