RE: drivers/staging/wilc1000/wilc_spi.c won't compile ?

RE: drivers/staging/wilc1000/wilc_spi.c won't compile ?

[Kim, Leo]

Hi David,

You're had old wilc1000 source.
Remove the wilc1000_ops structure.
 (Branch) staging-testing
 (SHA) ce7b516f3f9e11fe4ee06fad0d7e853bb6e8f160
Please receive the latest source.

 Thanks, BR
 Leo

-----Original Message-----
From: David Binderman [mailto:dcb314@hotmail.com] 
Sent: Monday, February 08, 2016 9:18 PM
To: Kim, Johnny <johnny.kim@atmel.com>; Shin, Austin <Austin.Shin@atmel.com>; Park, Chris <Chris.Park@atmel.com>; Cho, Tony <Tony.Cho@atmel.com>; Lee, Glen <Glen.Lee@atmel.com>; Kim, Leo <Leo.Kim@atmel.com>; linux-wireless@vger.kernel.org
Subject: drivers/staging/wilc1000/wilc_spi.c won't compile ?

Hello there,

drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of 'wilc1000_spi_ops' isn't known
 static const struct wilc1000_ops wilc1000_spi_ops;
                                  ^~~~~~~~~~~~~~~~
drivers/staging/wilc1000/wilc_spi.c:123:34: warning: 'wilc1000_spi_ops' defined but not used [-Wunused-const-variable]

Suggest remove.

Regards

David Binderman

 		 	   		  

Re: drivers/staging/wilc1000/wilc_spi.c won't compile ?

[Tony Cho]

Hi David,

Please check the latest update from the https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/?h=staging-testing.

The tree is not updated yet with the latest.

Thanks,

Tony.



On 2016년 02월 16일 20:33, David Binderman wrote:
> Hello there,
>
> ----------------------------------------
>> You're had old wilc1000 source.
>> Remove the wilc1000_ops structure.
>> (Branch) staging-testing
>> (SHA) ce7b516f3f9e11fe4ee06fad0d7e853bb6e8f160
>> Please receive the latest source.
>>
> I checked the Torvalds source for 4.5-rc4
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/wilc1000/wilc_spi.c?id=refs/tags/v4.5-rc4
>
> and the problem still seems to exist.
>
> Maybe your recent changes aren't getting from staging into the Torvalds tree ?
>
>
> Regards
>
> David Binderman
>
>>   Thanks, BR
>>   Leo
>>
>> -----Original Message-----
>> From: David Binderman [mailto:dcb314@hotmail.com]
>> Sent: Monday, February 08, 2016 9:18 PM
>> To: Kim, Johnny <johnny.kim@atmel.com>; Shin, Austin <Austin.Shin@atmel.com>; Park, Chris <Chris.Park@atmel.com>; Cho, Tony <Tony.Cho@atmel.com>; Lee, Glen <Glen.Lee@atmel.com>; Kim, Leo <Leo.Kim@atmel.com>; linux-wireless@vger.kernel.org
>> Subject: drivers/staging/wilc1000/wilc_spi.c won't compile ?
>>
>> Hello there,
>>
>> drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of 'wilc1000_spi_ops' isn't known
>>   static const struct wilc1000_ops wilc1000_spi_ops;
>>                                    ^~~~~~~~~~~~~~~~
>> drivers/staging/wilc1000/wilc_spi.c:123:34: warning: 'wilc1000_spi_ops' defined but not used [-Wunused-const-variable]
>>
>> Suggest remove.
>>
>> Regards
>>
>> David Binderman
>>
>>
>