* [PATCH] nl80211: use ieee80211_band in kernel space
@ 2016-02-25 11:32 Arend van Spriel
2016-02-25 12:59 ` Arend Van Spriel
0 siblings, 1 reply; 3+ messages in thread
From: Arend van Spriel @ 2016-02-25 11:32 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Arend van Spriel
The enumeration nl80211_band intends to expose the public part of
ieee80211_band enumeration. As such it should not be used in the
kernel. This patch changes nl80211_band usage to ieee80211_band.
Reported-by: kbuild robot <lkp@intel.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
include/net/cfg80211.h | 4 ++--
net/wireless/nl80211.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 1dfb890..c6ddb69 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -1863,7 +1863,7 @@ struct cfg80211_ibss_params {
* @delta: value of RSSI level adjustment.
*/
struct cfg80211_bss_select_adjust {
- enum nl80211_band band;
+ enum ieee80211_band band;
s8 delta;
};
@@ -1878,7 +1878,7 @@ struct cfg80211_bss_select_adjust {
struct cfg80211_bss_selection {
enum nl80211_bss_select_attr behaviour;
union {
- enum nl80211_band band_pref;
+ enum ieee80211_band band_pref;
struct cfg80211_bss_select_adjust adjust;
} param;
};
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 52ce26f..1f6d8e4 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5786,7 +5786,7 @@ static int validate_scan_freqs(struct nlattr *freqs)
return n_channels;
}
-static bool is_band_valid(struct wiphy *wiphy, enum nl80211_band b)
+static bool is_band_valid(struct wiphy *wiphy, enum ieee80211_band b)
{
return b < IEEE80211_NUM_BANDS && wiphy->bands[b];
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nl80211: use ieee80211_band in kernel space
2016-02-25 11:32 [PATCH] nl80211: use ieee80211_band in kernel space Arend van Spriel
@ 2016-02-25 12:59 ` Arend Van Spriel
2016-03-03 15:03 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Arend Van Spriel @ 2016-02-25 12:59 UTC (permalink / raw)
To: Arend van Spriel, Johannes Berg; +Cc: linux-wireless
On 25-2-2016 12:32, Arend van Spriel wrote:
> The enumeration nl80211_band intends to expose the public part of
> ieee80211_band enumeration. As such it should not be used in the
> kernel. This patch changes nl80211_band usage to ieee80211_band.
>
Fixes: 59ad2160c285 ("nl80211: add feature for BSS selection support")
Not sure if it is any of the trees already.
> Reported-by: kbuild robot <lkp@intel.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> include/net/cfg80211.h | 4 ++--
> net/wireless/nl80211.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 1dfb890..c6ddb69 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -1863,7 +1863,7 @@ struct cfg80211_ibss_params {
> * @delta: value of RSSI level adjustment.
> */
> struct cfg80211_bss_select_adjust {
> - enum nl80211_band band;
> + enum ieee80211_band band;
> s8 delta;
> };
>
> @@ -1878,7 +1878,7 @@ struct cfg80211_bss_select_adjust {
> struct cfg80211_bss_selection {
> enum nl80211_bss_select_attr behaviour;
> union {
> - enum nl80211_band band_pref;
> + enum ieee80211_band band_pref;
> struct cfg80211_bss_select_adjust adjust;
> } param;
> };
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 52ce26f..1f6d8e4 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -5786,7 +5786,7 @@ static int validate_scan_freqs(struct nlattr *freqs)
> return n_channels;
> }
>
> -static bool is_band_valid(struct wiphy *wiphy, enum nl80211_band b)
> +static bool is_band_valid(struct wiphy *wiphy, enum ieee80211_band b)
> {
> return b < IEEE80211_NUM_BANDS && wiphy->bands[b];
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nl80211: use ieee80211_band in kernel space
2016-02-25 12:59 ` Arend Van Spriel
@ 2016-03-03 15:03 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2016-03-03 15:03 UTC (permalink / raw)
To: arend; +Cc: linux-wireless
On Thu, 2016-02-25 at 13:59 +0100, Arend Van Spriel wrote:
> On 25-2-2016 12:32, Arend van Spriel wrote:
> > The enumeration nl80211_band intends to expose the public part of
> > ieee80211_band enumeration. As such it should not be used in the
> > kernel. This patch changes nl80211_band usage to ieee80211_band.
> >
> Fixes: 59ad2160c285 ("nl80211: add feature for BSS selection
> support")
>
> Not sure if it is any of the trees already.
>
I'm tempted to just get rid of ieee80211_band and move the NUM thing to
nl80211.h.
Thoughts?
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-03 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 11:32 [PATCH] nl80211: use ieee80211_band in kernel space Arend van Spriel
2016-02-25 12:59 ` Arend Van Spriel
2016-03-03 15:03 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).