From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Eliad Peller <eliad@wizery.com>, Arend van Spriel <arend@broadcom.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V10 1/2] nl80211: add feature for BSS selection support
Date: Tue, 1 Mar 2016 21:04:23 +0100 [thread overview]
Message-ID: <56D5F5C7.40204@broadcom.com> (raw)
In-Reply-To: <CAB3XZEehKfMzRgfbDkwWieKrzAAXwBcNbAMNGfhn6qBRAktGdA@mail.gmail.com>
On 1-3-2016 9:42, Eliad Peller wrote:
> On Mon, Feb 29, 2016 at 11:44 AM, Arend van Spriel <arend@broadcom.com> wrote:
>> Introducing a new feature that the driver can use to
>> indicate the driver/firmware supports configuration of BSS
>> selection criteria upon CONNECT command. This can be useful
>> when multiple BSS-es are found belonging to the same ESS,
>> ie. Infra-BSS with same SSID. The criteria can then be used to
>> offload selection of a preferred BSS.
>>
> [...]
>
>> + /* only do bss selection when no BSSID is specified. */
>> + if (!connect.bssid && info->attrs[NL80211_ATTR_BSS_SELECT]) {
>> + if (connect.bssid) {
>
> i guess you wanted to remove the !connect.bssid condition in the outer if :)
> other than that, looks go to me.
Good guess. Will fix that.
Regards,
Arend
prev parent reply other threads:[~2016-03-01 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 9:44 [PATCH V10 1/2] nl80211: add feature for BSS selection support Arend van Spriel
2016-02-29 9:44 ` [PATCH V10 2/2] brcmfmac: add support for nl80211 BSS_SELECT feature Arend van Spriel
2016-03-01 8:42 ` [PATCH V10 1/2] nl80211: add feature for BSS selection support Eliad Peller
2016-03-01 20:04 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5F5C7.40204@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=arend@broadcom.com \
--cc=eliad@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).