From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: egrumbach@gmail.com
Subject: Re: [PATCH v2 2/2] mac80211: minstrel_ht: set A-MSDU tx limits based on selected max_prob_rate
Date: Thu, 3 Mar 2016 16:03:34 +0100 [thread overview]
Message-ID: <56D85246.8070306@openwrt.org> (raw)
In-Reply-To: <1457016949.2044.12.camel@sipsolutions.net>
On 2016-03-03 15:55, Johannes Berg wrote:
> On Wed, 2016-02-24 at 10:29 +0100, Felix Fietkau wrote:
>
>> + /*
>> + * If the rate is slower than single-stream MCS4, limit A-MSDU to usual
>> + * data packet size
>> + */
>> + if (g->duration[rate] > MCS_DURATION(1, 0, 104))
>> + return 1500;
>> +
>> + /*
>> + * If the rate is slower than single-stream MCS7, limit A-MSDU to twice
>> + * the usual data packet size
>> + */
>> + if (g->duration[rate] > MCS_DURATION(1, 0, 260))
>> + return 3000;
>
> This isn't *quite* right, since you have to take an 802.11 header (vs.
> an ethernet header) into account, I think?
It's only a rough approximation anyway to prevent very large A-MSDUs
from being created with low rates.
- Felix
next prev parent reply other threads:[~2016-03-03 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 9:28 [PATCH v2 1/2] mac80211: add A-MSDU tx support Felix Fietkau
2016-02-24 9:29 ` [PATCH v2 2/2] mac80211: minstrel_ht: set A-MSDU tx limits based on selected max_prob_rate Felix Fietkau
2016-03-03 14:55 ` Johannes Berg
2016-03-03 15:03 ` Felix Fietkau [this message]
2016-03-03 15:07 ` Johannes Berg
2016-03-03 15:12 ` Felix Fietkau
2016-03-03 14:54 ` [PATCH v2 1/2] mac80211: add A-MSDU tx support Johannes Berg
2016-03-03 15:11 ` Felix Fietkau
2016-03-03 15:37 ` Johannes Berg
2016-03-03 15:55 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D85246.8070306@openwrt.org \
--to=nbd@openwrt.org \
--cc=egrumbach@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).