* Re: linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ?
[not found] <DUB128-W5980055F8A15A7CABF8D689C890@phx.gbl>
@ 2016-03-15 14:33 ` Larry Finger
0 siblings, 0 replies; only message in thread
From: Larry Finger @ 2016-03-15 14:33 UTC (permalink / raw)
To: David Binderman, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org
On 03/15/2016 05:50 AM, David Binderman wrote:
> Hello there,
>
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.gm
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pga
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.pad
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1851]: (error) Uninitialized struct member: gains.dac
>
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.gm
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pga
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.pad
> [linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c:1853]: (error) Uninitialized struct member: gains.dac
>
> I've had a look at the code and I can't see how local structure 'gains' get initialised.
It does not get initialized; however, it is only used in calls to
lpphy_papd_cal() that does nothing. Thus, no harm, no foul.
You should prepare a patch that initializes it to zero in line 1837.
Larry
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-03-15 14:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <DUB128-W5980055F8A15A7CABF8D689C890@phx.gbl>
2016-03-15 14:33 ` linux-4.5/drivers/net/wireless/broadcom/b43/phy_lp.c: 1851: maybe uninit data ? Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).