From: Larry Finger <Larry.Finger@lwfinger.net>
To: Arnd Bergmann <arnd@arndb.de>,
Chaoming Li <chaoming_li@realsil.com.cn>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: fix gcc-6 indentation warning
Date: Thu, 17 Mar 2016 11:09:41 -0500 [thread overview]
Message-ID: <56EAD6C5.9030208@lwfinger.net> (raw)
In-Reply-To: <1458209066-3979295-1-git-send-email-arnd@arndb.de>
On 03/17/2016 05:03 AM, Arnd Bergmann wrote:
> The rtl8821ae_dm_txpower_tracking_callback_thermalmeter function
> contains a call to RT_TRACE() that is indented in a misleading
> way, as pointed out by a gcc-6 warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function 'rtl8821ae_dm_txpower_tracking_callback_thermalmeter':
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2491:4: error: statement is indented as if it were guarded by...
> RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
> ^~~~~~~~
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2488:3: note: ...this 'for' clause, but it is not
> for (p = RF90_PATH_A; p < MAX_PATH_NUM_8821A; p++)
> ^~~
>
> It is clear from the context that the call was not meant to be
> part of the loop and only the indentation is wrong, so this
> removes the extra tabs.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
> index 95dcbff4673b..6a8245c4ea48 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c
> @@ -2488,9 +2488,9 @@ void rtl8821ae_dm_txpower_tracking_callback_thermalmeter(
> for (p = RF90_PATH_A; p < MAX_PATH_NUM_8821A; p++)
> rtldm->swing_idx_ofdm_base[p] = rtldm->swing_idx_ofdm[p];
>
> - RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
> - "pDM_Odm->RFCalibrateInfo.ThermalValue = %d ThermalValue= %d\n",
> - rtldm->thermalvalue, thermal_value);
> + RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
> + "pDM_Odm->RFCalibrateInfo.ThermalValue = %d ThermalValue= %d\n",
> + rtldm->thermalvalue, thermal_value);
> /*Record last Power Tracking Thermal Value*/
> rtldm->thermalvalue = thermal_value;
> }
>
This change looks good to me.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
next prev parent reply other threads:[~2016-03-17 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 10:03 [PATCH] rtlwifi: fix gcc-6 indentation warning Arnd Bergmann
2016-03-17 16:09 ` Larry Finger [this message]
2016-03-23 15:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EAD6C5.9030208@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).