linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pat Erley <pat-lkml@erley.org>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	linux-wireless@vger.kernel.org
Cc: Sara Sharon <sara.sharon@intel.com>
Subject: Re: [PATCH 23/43] iwlwifi: remove support for fw older than -16.ucode
Date: Sat, 23 Apr 2016 23:30:51 -0700	[thread overview]
Message-ID: <571C681B.2090604@erley.org> (raw)
In-Reply-To: <1459346715-7954-23-git-send-email-emmanuel.grumbach@intel.com>

This patch broke ucode loading on iwl6050 hardware.

[   12.666080] iwlwifi 0000:03:00.0: Direct firmware load for 
iwlwifi-6050-exp.ucode failed with error -2
[   12.672318] iwlwifi 0000:03:00.0: Driver unable to support your 
firmware API. Driver supports v5, firmware is v689702145.
[   12.676429] iwlwifi 0000:03:00.0: Driver unable to support your 
firmware API. Driver supports v5, firmware is v164168705.
[   12.676631] iwlwifi 0000:03:00.0: no suitable firmware found!

My guess is this block:

 >
> -	if (fw_has_api(&drv->fw.ucode_capa, IWL_UCODE_TLV_API_NEW_VERSION))
> -		api_ver = drv->fw.ucode_ver;
> -	else
> -		api_ver = IWL_UCODE_API(drv->fw.ucode_ver);
> +	api_ver = drv->fw.ucode_ver;
>


is still required for some devices on DVM?

After reverting this patch:

[ 2947.082256] iwlwifi 0000:03:00.0: Direct firmware load for 
iwlwifi-6050-exp.ucode failed with error -2
[ 2947.082880] iwlwifi 0000:03:00.0: loaded firmware version 41.28.5.1 
build 33926 op_mode iwldvm
[ 2947.095203] iwlwifi 0000:03:00.0: CONFIG_IWLWIFI_DEBUG enabled
[ 2947.095207] iwlwifi 0000:03:00.0: CONFIG_IWLWIFI_DEBUGFS disabled
[ 2947.095211] iwlwifi 0000:03:00.0: CONFIG_IWLWIFI_DEVICE_TRACING disabled
[ 2947.095214] iwlwifi 0000:03:00.0: Detected Intel(R) Centrino(R) 
Advanced-N + WiMAX 6250 AGN, REV=0x84
[ 2947.095557] iwlwifi 0000:03:00.0: L1 Enabled - LTR Disabled
[ 2947.117923] ieee80211 phy0: Selected rate control algorithm 'iwl-agn-rs'

Everything is working.

  reply	other threads:[~2016-04-24  6:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 14:04 pull request: iwlwifi-next 2016-03-30 Grumbach, Emmanuel
2016-03-30 14:04 ` [PATCH 01/43] iwlwifi: pcie: clear trans reference on queue stop Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 02/43] iwlwifi: mvm: Decrease size of the paging download buffer Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 03/43] iwlwifi: mvm: make sure FW contains the right amount of paging sections Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 04/43] iwlwifi: mvm: support dumping UMAC internal txfifos Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 05/43] iwlwifi: mvm: add LQM vendor command and notification Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 06/43] iwlwifi: add a debugfs hook for LQM Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 07/43] iwlwifi: pcie: fix global table size Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 08/43] iwlwifi: pcie: enable interrupts explicitly on resume Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 09/43] iwlwifi: pcie: refcounting is not necessary anymore Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 10/43] iwlwifi: mvm: handle async temperature notification with unlocked mutex Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 11/43] iwlwifi: pcie: print error value as signed int Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 12/43] iwlwifi: mvm: modify the max SP to infinite Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 13/43] iwlwifi: pcie: do not pad QoS AMSDU Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 14/43] iwlwifi: mvm: add support for new TX CMD API Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 15/43] iwlwifi: add missing mutex_destroy statements Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 16/43] iwlwifi: make uapsd_disable module param a bitmap Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 17/43] iwlwifi: 9000: update device id and FW serial number Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 18/43] iwlwifi: mvm: remove is_data_qos variable in TX Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 19/43] iwlwifi: mvm: support bss dynamic alloc/dealloc of queues Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 20/43] iwlwifi: pcie: write to legacy register also in MQ Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 21/43] iwlwifi: remove IWLWIFI_UAPSD Kconfig Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 22/43] iwlwifi: mvm: update GSCAN capabilities Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 23/43] iwlwifi: remove support for fw older than -16.ucode Emmanuel Grumbach
2016-04-24  6:30   ` Pat Erley [this message]
2016-04-25 13:05     ` Kalle Valo
2016-03-30 14:04 ` [PATCH 24/43] iwlwifi: dvm: use alloc_ordered_workqueue() Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 25/43] iwlwifi: mvm: report checksum is done also for IPv6 packets Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 26/43] iwlwifi: mvm: set aux STA ID in scan config Emmanuel Grumbach
2016-03-30 14:04 ` [PATCH 27/43] iwlwifi: trans: fix iwl_trans_txq_scd_cfg.sta_id sign Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 28/43] iwlwifi: mvm: remove uneeded D0I3 checking Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 29/43] iwlwifi: pcie: request one more interrupt vector Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 30/43] iwlwifi: mvm: improve RSS configuration Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 31/43] iwlwifi: edit the 9000 series PCI IDs Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 32/43] iwlwifi: mvm: use bss client queue for bss station Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 33/43] iwlwifi: mvm: set sta_id in SCD_QUEUE_CONFIG cmd Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 34/43] iwlwifi: mvm: allocate dedicated queue for cab in dqa mode Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 35/43] iwlwifi: mvm: move cmd queue to be #0 " Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 36/43] iwlwifi: mvm: add a scan timeout for regular scans Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 37/43] iwlwifi: mvm: enable TCP/UDP checksum support for 9000 family Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 38/43] iwlwifi: remove IWL_*_UCODE_API_OK Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 39/43] iwlwifi: pcie: Fix index iteration on free_irq in MSIX mode Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 40/43] iwlwifi: store fw memory segments length and addresses in run-time Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 41/43] iwlwifi: mvm: fix inconsistent lock in dqa mode Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 42/43] iwlwifi: mvm: allow setting the thermal state in D0i3 Emmanuel Grumbach
2016-03-30 14:05 ` [PATCH 43/43] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Emmanuel Grumbach
2016-04-06 18:17 ` pull request: iwlwifi-next 2016-03-30 Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571C681B.2090604@erley.org \
    --to=pat-lkml@erley.org \
    --cc=emmanuel.grumbach@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sara.sharon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).