From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add vht cap decode to debugfs.
Date: Mon, 2 May 2016 14:27:22 -0700 [thread overview]
Message-ID: <5727C63A.7020705@candelatech.com> (raw)
In-Reply-To: <1462224233.5898.22.camel@sipsolutions.net>
On 05/02/2016 02:23 PM, Johannes Berg wrote:
>
>> + if (vhtc->cap & IEEE80211_VHT_CAP_ ## a)+
>> p += scnprintf(p, sizeof(buf) + buf
>> - p, \
>> + "\t\t%s\n", b);
>
> Why not use #a instead of b?
>
>> + PFLAG(MAX_MPDU_LENGTH_3895, "MAX-MPDU-3895");
>
>
> Makes that a bit longer in the printout, but makes the code shorter.
I don't care that much either way, but it seemed nicer to customize the output.
It at least won't change the actual compiled code much...
I'll change it to be as you suggest if you want.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2016-05-02 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 21:19 [PATCH] mac80211: add vht cap decode to debugfs greearb
2016-05-02 21:23 ` Johannes Berg
2016-05-02 21:27 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5727C63A.7020705@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).