Re: [PATCH] ath10k: Fix 10.4 extended peer stats update

[Ben Greear <greearb@candelatech.com>]

On 05/10/2016 09:40 AM, Mohammed Shafi Shajakhan wrote:
> On Tue, May 10, 2016 at 09:34:55AM -0700, Ben Greear wrote:
>> On 05/10/2016 09:27 AM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>>>
>>> 10.4 'extended peer stats' will be not be appended with normal peer stats
>>> data and they shall be coming in separate chunks. Fix this by maintaining
>>> a separate linked list 'extender peer stats' for 10.4 and update
>>> rx_duration for per station statistics. Also parse through beacon filter
>>> (if enabled), to make sure we parse the extended peer stats properly.
>>> This issue was exposed when more than one client is connected and
>>> extended peer stats for 10.4 is enabled
>>
>> In general, maybe more of these stats should be kept in the driver instead
>> of the firmware?  The firmware is very tight on RAM already, and if
>> we can pass the needed info back to the host, it could gather arbitrary
>> amounts of stats as needed.
>>
>
> [shafi] agreed, probably thats why we are tracking u64 counters like rx_duration
> etc in host while the firmware variable will wrap aroud in sometime

If firmware could be modified to return more per-frame info, then the driver
could do virtually all of the stats gathering.  It would cost a bit of RAM
to hold that descriptor information, but over-all, the firmware might be a lot
simpler....

On the TX side, it would also allow intelligent host-based rate-ctrl.  Especially
considering the complexity of mu-mimo, it might be nice to get rate-ctrl into the
kernel where more people can work on it in a more flexible manner.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com