Re: [PATCH v9 18/21] wifi: nxpwifi: add core driver implementation

[Krzysztof Kozlowski <krzk@kernel.org>]

On 04/02/2026 19:03, Jeff Chen wrote:
> This patch introduces the core layer of the nxpwifi driver, which provides
> the foundational logic and infrastructure for managing the wireless
> adapter.
> 

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> +
> +	/* Notify PM core we are wakeup source */
> +	pm_wakeup_event(adapter->dev, 0);
> +	pm_system_wakeup();
> +
> +	return IRQ_HANDLED;
> +}
> +
> +static void nxpwifi_probe_of(struct nxpwifi_adapter *adapter)

NAK, you removed DT support thus cannot keep undocumented ABI.


> +{
> +	int ret;
> +	struct device *dev = adapter->dev;
> +
> +	if (!dev->of_node)
> +		goto err_exit;
> +
> +	adapter->dt_node = dev->of_node;

NAK

> +	adapter->irq_wakeup = irq_of_parse_and_map(adapter->dt_node, 0);
> +	if (!adapter->irq_wakeup) {
> +		nxpwifi_dbg(adapter, ERROR, "fail to parse irq_wakeup from device tree\n");
> +		goto err_exit;
> +	}
> +
> +	ret = devm_request_irq(dev, adapter->irq_wakeup,
> +			       nxpwifi_irq_wakeup_handler,
> +			       IRQF_TRIGGER_LOW | IRQF_NO_AUTOEN,
> +			       "wifi_wake", adapter);
> +	if (ret) {
> +		nxpwifi_dbg(adapter, ERROR, "Failed to request irq_wakeup %d (%d)\n",
> +			    adapter->irq_wakeup, ret);
> +		goto err_exit;
> +	}
> +
> +	if (device_init_wakeup(dev, true)) {
> +		nxpwifi_dbg(adapter, ERROR, "fail to init wakeup for nxpwifi\n");
> +		goto err_exit;
> +	}
> +	return;
> +
> +err_exit:
> +	adapter->irq_wakeup = -1;
> +}


Best regards,
Krzysztof