From: Guenter Roeck <linux@roeck-us.net>
To: "Michael Büsch" <m@bues.ch>
Cc: Kalle Valo <kvalo@codeaurora.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] b43: Remove unused phy_a code
Date: Fri, 3 Jun 2016 17:50:00 -0700 [thread overview]
Message-ID: <575225B8.2040607@roeck-us.net> (raw)
In-Reply-To: <20160603233519.4606b1ef@wiggum>
On 06/03/2016 02:35 PM, Michael Büsch wrote:
> On Fri, 3 Jun 2016 14:32:46 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> gcc-6 reports the following error with -Werror=unused-const-variable.
>>
>> drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
>> 'b43_phyops_a' defined but not used
>>
>> Turns out a lot of code in this file is unused, so let's remove it.
>
>
> All a-phy code is usused.
> So you can basically remove the whole file and any other A-PHY code.
I love removing code. I'll resend with more code removed.
Guenter
prev parent reply other threads:[~2016-06-04 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 21:32 [PATCH] b43: Remove unused phy_a code Guenter Roeck
2016-06-03 21:35 ` Michael Büsch
2016-06-04 0:50 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575225B8.2040607@roeck-us.net \
--to=linux@roeck-us.net \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).