From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: NL80211_ATTR_PAD question
Date: Fri, 10 Jun 2016 15:40:05 -0700 [thread overview]
Message-ID: <575B41C5.7010608@candelatech.com> (raw)
In-Reply-To: <1465592932.2308.6.camel@sipsolutions.net>
On 06/10/2016 02:08 PM, Johannes Berg wrote:
> On Fri, 2016-06-10 at 12:47 -0700, Ben Greear wrote:
>> I see this was added sometime recently: NL80211_ATTR_PAD
>>
>> If another enum member is added, should it replace the PAD enum?
>
> No.
>
>> At the least, I think we need some comments about how this is to be
>> dealt with.
>>
>
> You simply ignore it :)
Please add a comment...it is normal behaviour to fill in 'pads' when
possible, and even when I looked up the commit message it wasn't exactly
clear what this member was for.
Even reading nla_put_u64_64bit offers no useful clues...I didn't follow
the call chain longer, probably somewhere it would start making sense,
but then again, this is netlink code, so who knows!
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-06-10 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 19:47 NL80211_ATTR_PAD question Ben Greear
2016-06-10 20:28 ` Arend van Spriel
2016-06-10 21:08 ` Johannes Berg
2016-06-10 22:40 ` Ben Greear [this message]
2016-06-13 19:25 ` Arend van Spriel
2016-06-21 9:36 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575B41C5.7010608@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).