From: Ben Greear <greearb@candelatech.com>
To: ath10k <ath10k@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Subject: Bug with: ath10k: enable parsing per station rx duration for 10.4?
Date: Mon, 20 Jun 2016 16:06:52 -0700 [thread overview]
Message-ID: <5768770C.5050305@candelatech.com> (raw)
I'm working on bringing up my hacked up version of 4.7 ath10k and 10.4 firmware, and I think
I may have found a regression.
My 10.4.3-ish firmware source has a bunch of:
if (stats_id == WMI_REQUEST_PEER_STAT)
logic in it. In other words, it is not using that id as a bitfield.
Now, I can fix the firmware, but I am guessing that at least some stock
10.4 firmware has this same issue, and of course any older firmware
that does not have this change will still be broken.
So, do you want to back out this patch below, at least the part where it sends
in 0x9 as the stats_id?
Or, is all available upstream 10.4 firmware OK with this and I should just fix mine?
Or possibly, this is all my fault and I somehow screwed up when rebasing....
Thanks,
Ben
Author: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> 2016-03-16 05:43:34
Committer: Kalle Valo <kvalo@qca.qualcomm.com> 2016-04-04 07:02:47
Parent: 47771902a9beb23859805721f1d98d03dee5da7c (ath10k: introduce Extended Resource Config support for 10.4)
Child: 59465fe46ef1c2caf2c1beca828c4f29d28b98ca (ath10k: speedup htt rx descriptor processing for tx completion)
Branches: master, master.stgit, remotes/origin/master, remotes/origin/master.stgit
Follows: v4.5-rc5
Precedes: v4.7-rc1
ath10k: enable parsing per station rx duration for 10.4
Rx duration support for per station is part of extended peer
stats, enable provision to parse the same and provide backward
compatibility based on the 'stats_id' event
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
....
@@ -1615,7 +1615,8 @@ static int ath10k_core_init_firmware_features(struct ath10k *ar)
ar->num_active_peers = TARGET_10_4_ACTIVE_PEERS;
ar->max_num_vdevs = TARGET_10_4_NUM_VDEVS;
ar->num_tids = TARGET_10_4_TGT_NUM_TIDS;
- ar->fw_stats_req_mask = WMI_STAT_PEER;
+ ar->fw_stats_req_mask = WMI_10_4_STAT_PEER |
+ WMI_10_4_STAT_PEER_EXTD;
ar->max_spatial_stream = ar->hw_params.max_spatial_stream;
if (test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL,
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next reply other threads:[~2016-06-20 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 23:06 Ben Greear [this message]
2016-06-21 5:18 ` Bug with: ath10k: enable parsing per station rx duration for 10.4? Mohammed Shafi Shajakhan
2016-06-21 14:10 ` Ben Greear
2016-06-21 15:41 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5768770C.5050305@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).