From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] nl80211: fix logic inversion in start_nan()
Date: Mon, 21 Nov 2016 13:57:08 +0100 [thread overview]
Message-ID: <576a08f1-3246-4e59-57a1-704e429674bd@broadcom.com> (raw)
In-Reply-To: <20161121125548.4730-1-johannes@sipsolutions.net>
On 21-11-2016 13:55, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Arend inadvertedly inverted the logic while converting to
> wdev_running(), fix that.
It was indeed inadvertedly.
Thanks,
Arend
> Fixes: 73c7da3dae1e ("cfg80211: add generic helper to check interface is running")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/wireless/nl80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 4e9bda49e957..e4f718e956d7 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -10625,7 +10625,7 @@ static int nl80211_start_nan(struct sk_buff *skb, struct genl_info *info)
> if (wdev->iftype != NL80211_IFTYPE_NAN)
> return -EOPNOTSUPP;
>
> - if (!wdev_running(wdev))
> + if (wdev_running(wdev))
> return -EEXIST;
>
> if (rfkill_blocked(rdev->rfkill))
>
next prev parent reply other threads:[~2016-11-21 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 12:55 [PATCH] nl80211: fix logic inversion in start_nan() Johannes Berg
2016-11-21 12:57 ` Arend Van Spriel [this message]
2016-11-21 12:58 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576a08f1-3246-4e59-57a1-704e429674bd@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox