From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/5] Improve wireless netdev detection
Date: Fri, 8 Jul 2016 10:31:26 -0500 [thread overview]
Message-ID: <577FC74E.3080903@gmail.com> (raw)
In-Reply-To: <1467991593.4837.7.camel@sipsolutions.net>
Hi Johannes,
>> Are you okay with the general approach?
>
> I see no issues with sending these events out. I'd like them to
> actually be reliable (if present) though, not double as you'd implied -
> but I didn't really understand in which cases you were expecting
> issues, was it only P2P-Device?
>
That seems to be the only special case. At least I didn't find any
other situations where a NEW_INTERFACE command can be called without a
corresponding net_device being created.
>> Are there any locking issues I
>> might be overlooking?
>
> Not that I'm aware of. All of the netdev/wdev handling should be
> protected by RTNL.
>
That was my understanding as well. Thanks.
Okay, let me spin up a v2 with patches 2+3 and 4+5 squished together.
Or do you want one big patch?
Regards,
-Denis
prev parent reply other threads:[~2016-07-08 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:08 [PATCH 0/5] Improve wireless netdev detection Denis Kenzior
2016-07-07 7:08 ` [PATCH 1/5] nl80211: Add nl80211_notify_iface Denis Kenzior
2016-07-07 7:08 ` [PATCH 2/5] core: Notify of new wireless netdevs Denis Kenzior
2016-07-07 7:08 ` [PATCH 3/5] nl80211: Emit NEW_INTERFACE only in special cases Denis Kenzior
2016-07-07 7:08 ` [PATCH 4/5] core: Notify when wireless netdev is removed Denis Kenzior
2016-07-07 7:08 ` [PATCH 5/5] nl80211: Emit DEL_INTERFACE only in special cases Denis Kenzior
2016-07-08 10:32 ` [PATCH 0/5] Improve wireless netdev detection Johannes Berg
2016-07-08 15:22 ` Denis Kenzior
2016-07-08 15:26 ` Johannes Berg
2016-07-08 15:31 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577FC74E.3080903@gmail.com \
--to=denkenz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).