From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Thomas Graf <tgraf@suug.ch>,
tom@herbertland.com
Subject: Re: Buggy rhashtable walking
Date: Fri, 05 Aug 2016 04:46:43 -0700 [thread overview]
Message-ID: <57A47CA3.4010101@candelatech.com> (raw)
In-Reply-To: <1470394233.2977.37.camel@sipsolutions.net>
On 08/05/2016 03:50 AM, Johannes Berg wrote:
> On Fri, 2016-08-05 at 18:48 +0800, Herbert Xu wrote:
>> On Fri, Aug 05, 2016 at 08:16:53AM +0200, Johannes Berg wrote:
>>>
>>> Hm. Would you rather allocate a separate head entry for the
>>> hashtable,
>>> or chain the entries?
>>
>> My plan is to build support for this directly into rhashtable.
>> So I'm adding a struct rhlist_head that would be used in place
>> of rhash_head for these cases and it'll carry an extra pointer
>> for the list of identical entries.
>>
>> I will then add an additional layer of insert/lookup interfaces
>> for rhlist_head.
Herbert, thank you for fixing this!
It would not be fun to have to revert to the old way of hashing
stations in mac80211...
I'll be happy to test the patches when you have them ready.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-08-05 11:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 7:18 Buggy rhashtable walking Herbert Xu
2016-08-04 7:45 ` Herbert Xu
2016-08-05 6:16 ` Johannes Berg
2016-08-05 10:48 ` Herbert Xu
2016-08-05 10:50 ` Johannes Berg
2016-08-05 11:46 ` Ben Greear [this message]
2016-08-08 15:26 ` Herbert Xu
2016-09-18 13:50 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Herbert Xu
2016-09-18 13:53 ` [PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-18 13:54 ` [PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 8:20 ` [PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 8:25 ` Johannes Berg
2016-09-19 8:35 ` Herbert Xu
2016-09-19 8:58 ` Johannes Berg
2016-09-19 8:40 ` [v2 PATCH " Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 8:42 ` [v2 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 9:15 ` [v2 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 9:17 ` Herbert Xu
2016-09-19 9:27 ` Johannes Berg
2016-09-19 9:31 ` Johannes Berg
2016-09-19 9:34 ` Herbert Xu
2016-09-19 9:38 ` Johannes Berg
2016-09-19 9:50 ` Johannes Berg
2016-09-19 9:54 ` Johannes Berg
2016-09-19 10:02 ` Johannes Berg
2016-09-19 10:04 ` Johannes Berg
2016-09-19 10:10 ` Johannes Berg
2016-09-19 10:48 ` Herbert Xu
2016-09-19 10:58 ` Johannes Berg
2016-09-19 10:58 ` [v3 " Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 1/2] rhashtable: Add rhlist interface Herbert Xu
2016-09-19 21:16 ` Thomas Graf
2016-09-20 1:52 ` Herbert Xu
2016-09-19 11:00 ` [v3 PATCH 2/2] mac80211: Use rhltable instead of rhashtable Herbert Xu
2016-09-19 11:03 ` [v3 PATCH 0/2] rhashtable: rhashtable with duplicate objects Johannes Berg
2016-09-19 11:32 ` Johannes Berg
2016-09-20 8:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A47CA3.4010101@candelatech.com \
--to=greearb@candelatech.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).