From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [RESEND PATCH] nl80211: Allow GET_INTERFACE dumps to be filtered
Date: Thu, 11 Aug 2016 13:20:40 -0500 [thread overview]
Message-ID: <57ACC1F8.6070908@gmail.com> (raw)
In-Reply-To: <1470938627.12075.25.camel@sipsolutions.net>
Hi Johannes,
>> Speaking of indentation, can you point me to a doc of the rules I
>> should follow?
>
> You've seen Documentation/CodingStyle?
Of course. But that one doesn't discuss that you want your function
parameters to be aligned to the opening '('. Is there a dialect
document specific to linux-wireless?
>
>> I can confirm that I sanity checked this patch. Both ATTR_WIPHY,
>> ATTR_WDEV and wildcard dumps seemed to produce expected results.
>
> I think it probably works due to the other conditions?
The initial conditions are that:
cb->args[0..2] == 0.
So on the first iteration we set filter_wiphy == -1 and check the filter
attributes. If set, we modify filter_wiphy accordingly.
Even if filter_wiphy is set to 0, the if statement should still never be
entered afterwards since wp_start and if_start are incremented.
Is this what you're worried about? Do you see a fault in my logic?
Regards,
-Denis
next prev parent reply other threads:[~2016-08-11 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 22:02 [RESEND PATCH] nl80211: Allow GET_INTERFACE dumps to be filtered Denis Kenzior
2016-08-11 12:47 ` Johannes Berg
2016-08-11 16:38 ` Denis Kenzior
2016-08-11 18:03 ` Johannes Berg
2016-08-11 18:20 ` Denis Kenzior [this message]
2016-08-11 18:58 ` Arend Van Spriel
2016-08-11 19:05 ` Denis Kenzior
2016-08-11 21:22 ` Arend Van Spriel
2016-08-12 5:58 ` Johannes Berg
2016-08-12 16:24 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ACC1F8.6070908@gmail.com \
--to=denkenz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).