From: Govind Singh <govinds@codeaurora.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Replace bit shifts with the BIT() macro for rx desc bits
Date: Wed, 09 May 2018 15:05:57 +0530 [thread overview]
Message-ID: <57eb66a936cb541e81cb9ba4f48df61b@codeaurora.org> (raw)
In-Reply-To: <20180509074042.GA768@gmail.com>
On 2018-05-09 13:10, Marcus Folkesson wrote:
> Hello Govind,
>
> On Wed, May 09, 2018 at 10:18:04AM +0530, Govind Singh wrote:
>> Use the BIT() macro from 'linux/bitops.h' to define the rx desc
>> bit flags to have consistency with new definitions.
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath10k/rx_desc.h | 134
>> +++++++++++-----------
>> 1 file changed, 67 insertions(+), 67 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/rx_desc.h
>> b/drivers/net/wireless/ath/ath10k/rx_desc.h
>> index 545deb6d7af1..b3d7c6e7ac90 100644
>> --- a/drivers/net/wireless/ath/ath10k/rx_desc.h
>> +++ b/drivers/net/wireless/ath/ath10k/rx_desc.h
>
> Looks good, but please include linux/bitops.h as well.
>
> From the documentation [1]:
>
> If you use a facility then #include the file that defines/declares
> that facility. Don't depend on other header files pulling in ones
> that you use.
>
Thanks, addressed the comment in v2 patchset.
>
> [1] Documentation/process/submit-checklist.rst
>
>
> Best regards
> Marcus Folkesson
prev parent reply other threads:[~2018-05-09 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 4:48 [PATCH] ath10k: Replace bit shifts with the BIT() macro for rx desc bits Govind Singh
2018-05-09 7:40 ` Marcus Folkesson
2018-05-09 9:35 ` Govind Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57eb66a936cb541e81cb9ba4f48df61b@codeaurora.org \
--to=govinds@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).