[PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Sriram R]

ath10k has a replay detection issue which was fixed in v4.14 and we would
like to get this security fix also to linux-stable-4.4.But for that it
depends on 3 mac80211 patches so the below mac80211 commits needs to be
picked first in the same order and then apply this patchset.

f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW crypto
f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames  
cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped

These patches should be applied in that order(commit f980ebc058c2 first)
and they should apply cleanly with 3-way merge.

Sriram R (2):
  ath10k: Add new hw param to identify alignment for different chipsets
  ath10k: rebuild crypto header in rx data frames

 drivers/net/wireless/ath/ath10k/core.c    |   8 +++
 drivers/net/wireless/ath/ath10k/core.h    |   4 ++
 drivers/net/wireless/ath/ath10k/htt_rx.c  | 108 +++++++++++++++++++++++++-----
 drivers/net/wireless/ath/ath10k/rx_desc.h |   3 +
 4 files changed, 107 insertions(+), 16 deletions(-)

-- 
2.7.4

[PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify alignment for different chipsets

[Sriram R]

Chipset QCA99X0 doesnot have rx_hdr_status padded to
align in 4-byte boundary.Hence define a new hw_params
field to handle different alignment behaviour between
different chipsets.

[Upstream commit : 2f38c3c01de945234d23dd163e3528ccb413066d]

Signed-off-by: Vasanthkumar Thiagarajan <vthiagar@codeaurora.org>
Signed-off-by: Sriram R <srirrama@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/core.c | 8 ++++++++
 drivers/net/wireless/ath/ath10k/core.h | 4 ++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index ee638cb..0c23768 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -67,6 +67,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA988X_BOARD_DATA_SZ,
 			.board_ext_size = QCA988X_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 	{
 		.id = QCA6174_HW_2_1_VERSION,
@@ -85,6 +86,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA6174_BOARD_DATA_SZ,
 			.board_ext_size = QCA6174_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 	{
 		.id = QCA6174_HW_2_1_VERSION,
@@ -103,6 +105,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA6174_BOARD_DATA_SZ,
 			.board_ext_size = QCA6174_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 	{
 		.id = QCA6174_HW_3_0_VERSION,
@@ -121,6 +124,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA6174_BOARD_DATA_SZ,
 			.board_ext_size = QCA6174_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 	{
 		.id = QCA6174_HW_3_2_VERSION,
@@ -140,6 +144,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA6174_BOARD_DATA_SZ,
 			.board_ext_size = QCA6174_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 	{
 		.id = QCA99X0_HW_2_0_DEV_VERSION,
@@ -159,6 +164,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA99X0_BOARD_DATA_SZ,
 			.board_ext_size = QCA99X0_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 1,
 	},
 	{
 		.id = QCA9377_HW_1_0_DEV_VERSION,
@@ -177,6 +183,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA9377_BOARD_DATA_SZ,
 			.board_ext_size = QCA9377_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 	{
 		.id = QCA9377_HW_1_1_DEV_VERSION,
@@ -195,6 +202,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 			.board_size = QCA9377_BOARD_DATA_SZ,
 			.board_ext_size = QCA9377_BOARD_EXT_DATA_SZ,
 		},
+		.decap_align_bytes = 4,
 	},
 };
 
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 858d75f..e4e3b41 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -670,6 +670,10 @@ struct ath10k {
 			size_t board_size;
 			size_t board_ext_size;
 		} fw;
+
+		/* Number of bytes used for alignment in rx_hdr_status */
+		int decap_align_bytes;
+
 	} hw_params;
 
 	const struct firmware *board;
-- 
2.7.4

[PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Sriram R]

Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and
HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done
on host (mac80211) rather than firmware. Rebuild cipher header
in every received data frames (that are notified through those
HTT interfaces) from the rx_hdr_status tlv available in the
rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED
flag for the packets which requires mac80211 PN/TSC check support
and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X,
and QCA99X0 currently need the rebuilding of cipher header to
perform PN/TSC check for replay attack.

[Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3]

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Signed-off-by: Sriram R <srirrama@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/htt_rx.c | 98 ++++++++++++++++++++++++++------
 1 file changed, 82 insertions(+), 16 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 8d20ecc..d26cb37 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1076,7 +1076,21 @@ static void ath10k_htt_rx_h_undecap_raw(struct ath10k *ar,
 	hdr = (void *)msdu->data;
 
 	/* Tail */
-	skb_trim(msdu, msdu->len - ath10k_htt_rx_crypto_tail_len(ar, enctype));
+	if (status->flag & RX_FLAG_IV_STRIPPED) {
+		skb_trim(msdu, msdu->len -
+			 ath10k_htt_rx_crypto_tail_len(ar, enctype));
+	} else {
+		/* MIC */
+		if ((status->flag & RX_FLAG_MIC_STRIPPED) &&
+		    enctype == HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2)
+			skb_trim(msdu, msdu->len - 8);
+
+		/* ICV */
+		if (status->flag & RX_FLAG_ICV_STRIPPED &&
+		    enctype != HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2)
+			skb_trim(msdu, msdu->len -
+				 ath10k_htt_rx_crypto_tail_len(ar, enctype));
+	}
 
 	/* MMIC */
 	if (!ieee80211_has_morefrags(hdr->frame_control) &&
@@ -1095,12 +1109,14 @@ static void ath10k_htt_rx_h_undecap_raw(struct ath10k *ar,
 static void ath10k_htt_rx_h_undecap_nwifi(struct ath10k *ar,
 					  struct sk_buff *msdu,
 					  struct ieee80211_rx_status *status,
-					  const u8 first_hdr[64])
+					  const u8 first_hdr[64],
+					  enum htt_rx_mpdu_encrypt_type enctype)
 {
 	struct ieee80211_hdr *hdr;
 	size_t hdr_len;
 	u8 da[ETH_ALEN];
 	u8 sa[ETH_ALEN];
+	int bytes_aligned = ar->hw_params.decap_align_bytes;
 
 	/* Delivered decapped frame:
 	 * [nwifi 802.11 header] <-- replaced with 802.11 hdr
@@ -1123,6 +1139,14 @@ static void ath10k_htt_rx_h_undecap_nwifi(struct ath10k *ar,
 	/* push original 802.11 header */
 	hdr = (struct ieee80211_hdr *)first_hdr;
 	hdr_len = ieee80211_hdrlen(hdr->frame_control);
+
+	if (!(status->flag & RX_FLAG_IV_STRIPPED)) {
+		memcpy(skb_push(msdu,
+				ath10k_htt_rx_crypto_param_len(ar, enctype)),
+		       (void *)hdr + round_up(hdr_len, bytes_aligned),
+			ath10k_htt_rx_crypto_param_len(ar, enctype));
+	}
+
 	memcpy(skb_push(msdu, hdr_len), hdr, hdr_len);
 
 	/* original 802.11 header has a different DA and in
@@ -1180,6 +1204,7 @@ static void ath10k_htt_rx_h_undecap_eth(struct ath10k *ar,
 	void *rfc1042;
 	u8 da[ETH_ALEN];
 	u8 sa[ETH_ALEN];
+	int bytes_aligned = ar->hw_params.decap_align_bytes;
 
 	/* Delivered decapped frame:
 	 * [eth header] <-- replaced with 802.11 hdr & rfc1042/llc
@@ -1203,6 +1228,14 @@ static void ath10k_htt_rx_h_undecap_eth(struct ath10k *ar,
 	/* push original 802.11 header */
 	hdr = (struct ieee80211_hdr *)first_hdr;
 	hdr_len = ieee80211_hdrlen(hdr->frame_control);
+
+	if (!(status->flag & RX_FLAG_IV_STRIPPED)) {
+		memcpy(skb_push(msdu,
+				ath10k_htt_rx_crypto_param_len(ar, enctype)),
+		       (void *)hdr + round_up(hdr_len, bytes_aligned),
+			ath10k_htt_rx_crypto_param_len(ar, enctype));
+	}
+
 	memcpy(skb_push(msdu, hdr_len), hdr, hdr_len);
 
 	/* original 802.11 header has a different DA and in
@@ -1216,10 +1249,12 @@ static void ath10k_htt_rx_h_undecap_eth(struct ath10k *ar,
 static void ath10k_htt_rx_h_undecap_snap(struct ath10k *ar,
 					 struct sk_buff *msdu,
 					 struct ieee80211_rx_status *status,
-					 const u8 first_hdr[64])
+					 const u8 first_hdr[64],
+					 enum htt_rx_mpdu_encrypt_type enctype)
 {
 	struct ieee80211_hdr *hdr;
 	size_t hdr_len;
+	int bytes_aligned = ar->hw_params.decap_align_bytes;
 
 	/* Delivered decapped frame:
 	 * [amsdu header] <-- replaced with 802.11 hdr
@@ -1231,6 +1266,14 @@ static void ath10k_htt_rx_h_undecap_snap(struct ath10k *ar,
 
 	hdr = (struct ieee80211_hdr *)first_hdr;
 	hdr_len = ieee80211_hdrlen(hdr->frame_control);
+
+	if (!(status->flag & RX_FLAG_IV_STRIPPED)) {
+		memcpy(skb_push(msdu,
+				ath10k_htt_rx_crypto_param_len(ar, enctype)),
+		       (void *)hdr + round_up(hdr_len, bytes_aligned),
+			ath10k_htt_rx_crypto_param_len(ar, enctype));
+	}
+
 	memcpy(skb_push(msdu, hdr_len), hdr, hdr_len);
 }
 
@@ -1265,13 +1308,15 @@ static void ath10k_htt_rx_h_undecap(struct ath10k *ar,
 					    is_decrypted);
 		break;
 	case RX_MSDU_DECAP_NATIVE_WIFI:
-		ath10k_htt_rx_h_undecap_nwifi(ar, msdu, status, first_hdr);
+		ath10k_htt_rx_h_undecap_nwifi(ar, msdu, status, first_hdr,
+					      enctype);
 		break;
 	case RX_MSDU_DECAP_ETHERNET2_DIX:
 		ath10k_htt_rx_h_undecap_eth(ar, msdu, status, first_hdr, enctype);
 		break;
 	case RX_MSDU_DECAP_8023_SNAP_LLC:
-		ath10k_htt_rx_h_undecap_snap(ar, msdu, status, first_hdr);
+		ath10k_htt_rx_h_undecap_snap(ar, msdu, status, first_hdr,
+					     enctype);
 		break;
 	}
 }
@@ -1314,7 +1359,8 @@ static void ath10k_htt_rx_h_csum_offload(struct sk_buff *msdu)
 
 static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
 				 struct sk_buff_head *amsdu,
-				 struct ieee80211_rx_status *status)
+				 struct ieee80211_rx_status *status,
+				 bool fill_crypt_header)
 {
 	struct sk_buff *first;
 	struct sk_buff *last;
@@ -1324,7 +1370,6 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
 	enum htt_rx_mpdu_encrypt_type enctype;
 	u8 first_hdr[64];
 	u8 *qos;
-	size_t hdr_len;
 	bool has_fcs_err;
 	bool has_crypto_err;
 	bool has_tkip_err;
@@ -1345,15 +1390,17 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
 	 * decapped header. It'll be used for undecapping of each MSDU.
 	 */
 	hdr = (void *)rxd->rx_hdr_status;
-	hdr_len = ieee80211_hdrlen(hdr->frame_control);
-	memcpy(first_hdr, hdr, hdr_len);
+	memcpy(first_hdr, hdr, RX_HTT_HDR_STATUS_LEN);
 
 	/* Each A-MSDU subframe will use the original header as the base and be
 	 * reported as a separate MSDU so strip the A-MSDU bit from QoS Ctl.
 	 */
 	hdr = (void *)first_hdr;
-	qos = ieee80211_get_qos_ctl(hdr);
-	qos[0] &= ~IEEE80211_QOS_CTL_A_MSDU_PRESENT;
+
+	if (ieee80211_is_data_qos(hdr->frame_control)) {
+		qos = ieee80211_get_qos_ctl(hdr);
+		qos[0] &= ~IEEE80211_QOS_CTL_A_MSDU_PRESENT;
+	}
 
 	/* Some attention flags are valid only in the last MSDU. */
 	last = skb_peek_tail(amsdu);
@@ -1387,11 +1434,17 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
 	if (has_tkip_err)
 		status->flag |= RX_FLAG_MMIC_ERROR;
 
-	if (is_decrypted)
+	if (is_decrypted) {
 		status->flag |= RX_FLAG_DECRYPTED |
-				RX_FLAG_IV_STRIPPED |
 				RX_FLAG_MMIC_STRIPPED;
 
+		if (fill_crypt_header)
+			status->flag |= RX_FLAG_MIC_STRIPPED |
+					RX_FLAG_ICV_STRIPPED;
+		else
+			status->flag |= RX_FLAG_IV_STRIPPED;
+	}
+
 	skb_queue_walk(amsdu, msdu) {
 		ath10k_htt_rx_h_csum_offload(msdu);
 		ath10k_htt_rx_h_undecap(ar, msdu, status, first_hdr, enctype,
@@ -1404,6 +1457,9 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
 		if (!is_decrypted)
 			continue;
 
+		if (fill_crypt_header)
+			continue;
+
 		hdr = (void *)msdu->data;
 		hdr->frame_control &= ~__cpu_to_le16(IEEE80211_FCTL_PROTECTED);
 	}
@@ -1414,6 +1470,9 @@ static void ath10k_htt_rx_h_deliver(struct ath10k *ar,
 				    struct ieee80211_rx_status *status)
 {
 	struct sk_buff *msdu;
+	struct sk_buff *first_subframe;
+
+	first_subframe = skb_peek(amsdu);
 
 	while ((msdu = __skb_dequeue(amsdu))) {
 		/* Setup per-MSDU flags */
@@ -1422,6 +1481,13 @@ static void ath10k_htt_rx_h_deliver(struct ath10k *ar,
 		else
 			status->flag |= RX_FLAG_AMSDU_MORE;
 
+		if (msdu == first_subframe) {
+			first_subframe = NULL;
+			status->flag &= ~RX_FLAG_ALLOW_SAME_PN;
+		} else {
+			status->flag |= RX_FLAG_ALLOW_SAME_PN;
+		}
+
 		ath10k_process_rx(ar, status, msdu);
 	}
 }
@@ -1607,7 +1673,7 @@ static void ath10k_htt_rx_handler(struct ath10k_htt *htt,
 		ath10k_htt_rx_h_ppdu(ar, &amsdu, rx_status, 0xffff);
 		ath10k_htt_rx_h_unchain(ar, &amsdu, ret > 0);
 		ath10k_htt_rx_h_filter(ar, &amsdu, rx_status);
-		ath10k_htt_rx_h_mpdu(ar, &amsdu, rx_status);
+		ath10k_htt_rx_h_mpdu(ar, &amsdu, rx_status, true);
 		ath10k_htt_rx_h_deliver(ar, &amsdu, rx_status);
 	}
 
@@ -1653,7 +1719,7 @@ static void ath10k_htt_rx_frag_handler(struct ath10k_htt *htt,
 
 	ath10k_htt_rx_h_ppdu(ar, &amsdu, rx_status, 0xffff);
 	ath10k_htt_rx_h_filter(ar, &amsdu, rx_status);
-	ath10k_htt_rx_h_mpdu(ar, &amsdu, rx_status);
+	ath10k_htt_rx_h_mpdu(ar, &amsdu, rx_status, true);
 	ath10k_htt_rx_h_deliver(ar, &amsdu, rx_status);
 
 	if (fw_desc_len > 0) {
@@ -1952,7 +2018,7 @@ static void ath10k_htt_rx_in_ord_ind(struct ath10k *ar, struct sk_buff *skb)
 			 */
 			ath10k_htt_rx_h_ppdu(ar, &amsdu, status, vdev_id);
 			ath10k_htt_rx_h_filter(ar, &amsdu, status);
-			ath10k_htt_rx_h_mpdu(ar, &amsdu, status);
+			ath10k_htt_rx_h_mpdu(ar, &amsdu, status, false);
 			ath10k_htt_rx_h_deliver(ar, &amsdu, status);
 			break;
 		case -EAGAIN:
-- 
2.7.4

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Greg KH]

On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote:
> Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and
> HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done
> on host (mac80211) rather than firmware. Rebuild cipher header
> in every received data frames (that are notified through those
> HTT interfaces) from the rx_hdr_status tlv available in the
> rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED
> flag for the packets which requires mac80211 PN/TSC check support
> and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X,
> and QCA99X0 currently need the rebuilding of cipher header to
> perform PN/TSC check for replay attack.
> 
> [Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3]
> 
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Signed-off-by: Sriram R <srirrama@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 98 ++++++++++++++++++++++++++------
>  1 file changed, 82 insertions(+), 16 deletions(-)

This patch breaks the build.  Always test build your patches!

thanks,

greg k-h

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Sriram R]

On 2018-05-01 00:39, Greg KH wrote:
> On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote:
>> Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and
>> HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done
>> on host (mac80211) rather than firmware. Rebuild cipher header
>> in every received data frames (that are notified through those
>> HTT interfaces) from the rx_hdr_status tlv available in the
>> rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED
>> flag for the packets which requires mac80211 PN/TSC check support
>> and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X,
>> and QCA99X0 currently need the rebuilding of cipher header to
>> perform PN/TSC check for replay attack.
>> 
>> [Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3]
>> 
>> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
>> Signed-off-by: Sriram R <srirrama@codeaurora.org>
>> ---
>>  drivers/net/wireless/ath/ath10k/htt_rx.c | 98 
>> ++++++++++++++++++++++++++------
>>  1 file changed, 82 insertions(+), 16 deletions(-)
> 
> This patch breaks the build.  Always test build your patches!
> 
> thanks,
> 
> greg k-h
Hi Greg,

   This patch along with its dependency patches (in the following order)

f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW 
crypto
f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames
cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped
[PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify 
alignment for different chipsets

build fine when checked with v4.4.130.

Kindly let me know if you face any issues while trying out in this 
order.

Thanks,
Sriram.R

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Sriram R]

On 2018-05-01 05:14, Sriram R wrote:
> On 2018-05-01 00:39, Greg KH wrote:
>> On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote:
>>> Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and
>>> HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done
>>> on host (mac80211) rather than firmware. Rebuild cipher header
>>> in every received data frames (that are notified through those
>>> HTT interfaces) from the rx_hdr_status tlv available in the
>>> rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED
>>> flag for the packets which requires mac80211 PN/TSC check support
>>> and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X,
>>> and QCA99X0 currently need the rebuilding of cipher header to
>>> perform PN/TSC check for replay attack.
>>> 
>>> [Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3]
>>> 
>>> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
>>> Signed-off-by: Sriram R <srirrama@codeaurora.org>
>>> ---
>>>  drivers/net/wireless/ath/ath10k/htt_rx.c | 98 
>>> ++++++++++++++++++++++++++------
>>>  1 file changed, 82 insertions(+), 16 deletions(-)
>> 
>> This patch breaks the build.  Always test build your patches!
>> 
>> thanks,
>> 
>> greg k-h
> Hi Greg,
> 
>   This patch along with its dependency patches (in the following order)
> 
> f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW 
> crypto
> f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames
> cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped
> [PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify
> alignment for different chipsets
> 
Hi Greg,

  I feel this breaks since the above mentioned mac80211 commits are not 
available in this queue.

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-4.4/series?id=8e2985dd801f00640be6998ec831018a688bb221

Could you please check after these commits are queued as well before 
this patch is applied.

Please let me know if i miss something here so i could check from my 
side as well.

Thanks,
Sriram.R
> build fine when checked with v4.4.130.
> 
> Kindly let me know if you face any issues while trying out in this 
> order.
> 
> Thanks,
> Sriram.R

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Greg KH]

On Tue, May 01, 2018 at 05:44:19AM +0530, Sriram R wrote:
> On 2018-05-01 05:14, Sriram R wrote:
> > On 2018-05-01 00:39, Greg KH wrote:
> > > On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote:
> > > > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and
> > > > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done
> > > > on host (mac80211) rather than firmware. Rebuild cipher header
> > > > in every received data frames (that are notified through those
> > > > HTT interfaces) from the rx_hdr_status tlv available in the
> > > > rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED
> > > > flag for the packets which requires mac80211 PN/TSC check support
> > > > and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X,
> > > > and QCA99X0 currently need the rebuilding of cipher header to
> > > > perform PN/TSC check for replay attack.
> > > > 
> > > > [Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3]
> > > > 
> > > > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> > > > Signed-off-by: Sriram R <srirrama@codeaurora.org>
> > > > ---
> > > >  drivers/net/wireless/ath/ath10k/htt_rx.c | 98
> > > > ++++++++++++++++++++++++++------
> > > >  1 file changed, 82 insertions(+), 16 deletions(-)
> > > 
> > > This patch breaks the build.  Always test build your patches!
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > Hi Greg,
> > 
> >   This patch along with its dependency patches (in the following order)
> > 
> > f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW
> > crypto
> > f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames
> > cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped
> > [PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify
> > alignment for different chipsets
> > 
> Hi Greg,
> 
>  I feel this breaks since the above mentioned mac80211 commits are not
> available in this queue.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-4.4/series?id=8e2985dd801f00640be6998ec831018a688bb221
> 
> Could you please check after these commits are queued as well before this
> patch is applied.
> 
> Please let me know if i miss something here so i could check from my side as
> well.

Ugh, you are right, I missed that in the cover leter, my fault.  I'll
blame the jet-lag :)

I'll go drop the first patch for now, and then look at all of these
again at the end of the week for the next round of releases.

thanks,

greg k-h

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Sriram R]

On 2018-05-01 20:30, Greg KH wrote:
> On Tue, May 01, 2018 at 05:44:19AM +0530, Sriram R wrote:
>> On 2018-05-01 05:14, Sriram R wrote:
>> > On 2018-05-01 00:39, Greg KH wrote:
>> > > On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote:
>> > > > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and
>> > > > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done
>> > > > on host (mac80211) rather than firmware. Rebuild cipher header
>> > > > in every received data frames (that are notified through those
>> > > > HTT interfaces) from the rx_hdr_status tlv available in the
>> > > > rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED
>> > > > flag for the packets which requires mac80211 PN/TSC check support
>> > > > and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X,
>> > > > and QCA99X0 currently need the rebuilding of cipher header to
>> > > > perform PN/TSC check for replay attack.
>> > > >
>> > > > [Upstream Commit : 7eccb738fce57cbe53ed903ccf43f9ab257b15b3]
>> > > >
>> > > > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
>> > > > Signed-off-by: Sriram R <srirrama@codeaurora.org>
>> > > > ---
>> > > >  drivers/net/wireless/ath/ath10k/htt_rx.c | 98
>> > > > ++++++++++++++++++++++++++------
>> > > >  1 file changed, 82 insertions(+), 16 deletions(-)
>> > >
>> > > This patch breaks the build.  Always test build your patches!
>> > >
>> > > thanks,
>> > >
>> > > greg k-h
>> > Hi Greg,
>> >
>> >   This patch along with its dependency patches (in the following order)
>> >
>> > f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW
>> > crypto
>> > f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames
>> > cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped
>> > [PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify
>> > alignment for different chipsets
>> >
>> Hi Greg,
>> 
>>  I feel this breaks since the above mentioned mac80211 commits are not
>> available in this queue.
>> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-4.4/series?id=8e2985dd801f00640be6998ec831018a688bb221
>> 
>> Could you please check after these commits are queued as well before 
>> this
>> patch is applied.
>> 
>> Please let me know if i miss something here so i could check from my 
>> side as
>> well.
> 
> Ugh, you are right, I missed that in the cover leter, my fault.  I'll
> blame the jet-lag :)
> 
> I'll go drop the first patch for now, and then look at all of these
> again at the end of the week for the next round of releases.
> 
> thanks,
> 
> greg k-h

Sure, Thanks Greg.

Regards,
Sriram.R

Re: [PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Greg KH]

On Mon, Apr 30, 2018 at 11:56:25AM +0530, Sriram R wrote:
> ath10k has a replay detection issue which was fixed in v4.14 and we would
> like to get this security fix also to linux-stable-4.4.But for that it
> depends on 3 mac80211 patches so the below mac80211 commits needs to be
> picked first in the same order and then apply this patchset.
> 
> f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW crypto
> f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames  
> cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped
> 
> These patches should be applied in that order(commit f980ebc058c2 first)
> and they should apply cleanly with 3-way merge.

Thanks, now queued up.

greg k-h

Re: [PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

[Greg KH]

On Mon, Apr 30, 2018 at 11:56:25AM +0530, Sriram R wrote:
> ath10k has a replay detection issue which was fixed in v4.14 and we would
> like to get this security fix also to linux-stable-4.4.But for that it
> depends on 3 mac80211 patches so the below mac80211 commits needs to be
> picked first in the same order and then apply this patchset.
> 
> f980ebc058c2 : mac80211: allow not sending MIC up from driver for HW crypto
> f631a77ba920 : mac80211: allow same PN for AMSDU sub-frames  
> cef0acd4d7d4 : mac80211: Add RX flag to indicate ICV stripped
> 
> These patches should be applied in that order(commit f980ebc058c2 first)
> and they should apply cleanly with 3-way merge.

Ok, let's try this again, now queued up :)

greg k-h