linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	Andrew Zaborowski <andrew.zaborowski@intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT
Date: Mon, 5 Dec 2016 08:55:38 -0600	[thread overview]
Message-ID: <58457FEA.4030305@gmail.com> (raw)
In-Reply-To: <1480945883.31788.3.camel@sipsolutions.net>

Hi Johannes,

On 12/05/2016 07:51 AM, Johannes Berg wrote:
> On Fri, 2016-12-02 at 21:56 +0100, Andrew Zaborowski wrote:
>> Disconnect or deauthenticate when the owning socket is closed if this
>> flag has been supplied to CMD_CONNECT, CMD_AUTHENTICATE or
>> CMD_ASSOCIATE.
>
> Huh. That I think needs a lot more commit log to justify this code -
> why do you think this would be useful? Connection managers dying don't
> really mean you need to disconnect immediately, after all, and if they
> restart it's pretty simple to detect the existing connection and
> perhaps even use it...
>

Detecting it is easy, sure.  But I'm a bit lost on how you propose to 
'use' it.  The connection is active up until the next rekey event.  If 
rekey offloading is supported, then this might never involve user space. 
  But if it isn't (and I can't get rekey offload to work on any recent 
kernel I tried) then how do you propose userspace obtains the rekey 
counter, or the various keys used in the connection?

What about all the other state information?  FT, Pre-Authentication, etc?

Can you point me to a connection manager that actually performs this 
'reuse' and not just simply wipes the state clean when starting?

Regards,
-Denis

  reply	other threads:[~2016-12-05 14:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 20:56 [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT Andrew Zaborowski
2016-12-05 13:51 ` Johannes Berg
2016-12-05 14:55   ` Denis Kenzior [this message]
2016-12-05 14:58     ` Johannes Berg
2016-12-05 15:05       ` Denis Kenzior
2016-12-05 15:14         ` Johannes Berg
2016-12-05 15:32           ` Denis Kenzior
2016-12-06  7:16             ` Johannes Berg
2016-12-06 21:42               ` Denis Kenzior
2016-12-07  1:40                 ` Andrew Zaborowski
2016-12-07  6:19                   ` Johannes Berg
2016-12-07  9:49                     ` Andrew Zaborowski
2016-12-07  6:15                 ` Johannes Berg
2016-12-07  6:40                   ` Denis Kenzior
2016-12-07  6:48                     ` Johannes Berg
2016-12-07  7:07                       ` Denis Kenzior
2016-12-07  7:38                         ` Johannes Berg
2016-12-05 15:40           ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58457FEA.4030305@gmail.com \
    --to=denkenz@gmail.com \
    --cc=andrew.zaborowski@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).