Re: [PATCH][RFC] cfg80211: NL80211_ATTR_SOCKET_OWNER support for CMD_CONNECT

[Denis Kenzior <denkenz@gmail.com>]

Hi Johannes,

On 12/06/2016 01:16 AM, Johannes Berg wrote:
> On Mon, 2016-12-05 at 09:32 -0600, Denis Kenzior wrote:
>
>> To what purpose?  That's like saying that maybe a socket should be
>> kept open in case an application crashes.
>
> That socket would be useless, so no, that's not comparable at all. It's
> more like saying the disk should be unmounted once 'mount' exits ;-)
>

Except the kernel doesn't want to reconfigure mount parameters every 
15-30 minutes.  So no, its not like 'mount' at all ;)  But I digress, I 
can see that we won't agree here.  But we still would like the kernel to 
clean up nicely if stuff hits the fan.

> Anyway ... I'm not even super against this patch, but you need to fix

I'm afraid to consider what you're like when you _are_ 'super' against 
something :)

> things:
>   * this is actually wrong for authenticate - I'll let you figure out
>     why by yourself

So here's a quick test, with the client triggering authenticate, then 
crashing:

< Request: Authenticate (0x25) len 52 [ack]                  362.339712
     Interface Index: 3 (0x00000003)
     Wiphy Frequency: 2417 (0x00000971)
     MAC Address <snip>
     SSID: len 9
         <snip>
     Auth Type: 0 (0x00000000)
 > Event: New Station (0x13) len 32                           362.341337
     Interface Index: 3 (0x00000003)
 > Response: Authenticate (0x25) len 4                        362.341860
     Status: Success (0)
 > Event: Authenticate (0x25) len 64                          362.343640
     Wiphy: 0 (0x00000000)
     Interface Index: 3 (0x00000003)
 > Event: Del Station (0x14) len 1144                         367.442024
     Interface Index: 3 (0x00000003)
     MAC Address <snip>

Pay attention to the time stamps.  The del station event comes in 5 
seconds or so after our client has aborted.  So for 5 seconds we have an 
unmanaged link to some AP.  It would be nice if the authentication was 
aborted as soon as we crash.

So again, why do you say that SOCKET_OWNER is 'wrong' for authenticate? 
  Or do you mean something else?

>   * you need to teach people to write useful commit messages

The commit description in this patch was lacking.  We both agree here.

Regards,
-Denis