From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Sascha Hauer" <sha@pengutronix.de>
Subject: Re: rtw88: alloc_skb(32768, GFP_ATOMIC) fails, driver gets stuck
Date: Thu, 3 Oct 2024 04:26:38 +0000 [thread overview]
Message-ID: <58f2db72612544c9a5f27e524f213243@realtek.com> (raw)
In-Reply-To: <878qv693g7.fsf@kernel.org>
> I did a quick look and in wireless drivers some of the alloc_skb()
> callers print an error and some fail silently. I think we should start
> printing errors for all alloc_skb() calls. Thoughts?
I think we don't always print an error because TCP protocol can guarantee
reliability and packets lost are normal. Also in memory limited platforms
it might be regular that fails allocating memory causing flooding log if
we always print an error.
Maybe print with rate limit is a choice? But this kind of log seems
unnecessary and annoying to users.
next prev parent reply other threads:[~2024-10-03 4:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 11:46 rtw88: USB devices randomly stop receiving anything Bitterblue Smith
2024-09-26 13:04 ` petter
2024-09-26 16:51 ` Bitterblue Smith
2024-09-27 6:44 ` petter
2024-09-29 11:43 ` Bitterblue Smith
2024-09-30 20:56 ` rtw88: alloc_skb(32768, GFP_ATOMIC) fails, driver gets stuck Bitterblue Smith
2024-10-01 1:25 ` Ping-Ke Shih
2024-10-07 22:03 ` Bitterblue Smith
2024-10-02 10:58 ` Kalle Valo
2024-10-03 4:26 ` Ping-Ke Shih [this message]
2024-10-06 15:43 ` Michał Pecio
2024-10-07 22:04 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58f2db72612544c9a5f27e524f213243@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).