From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BB3C433E0 for ; Tue, 26 Jan 2021 22:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CF492067B for ; Tue, 26 Jan 2021 22:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730098AbhAZWrE (ORCPT ); Tue, 26 Jan 2021 17:47:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405825AbhAZU4B (ORCPT ); Tue, 26 Jan 2021 15:56:01 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75E23C06174A; Tue, 26 Jan 2021 12:55:20 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1l4VMh-00C2sE-Kg; Tue, 26 Jan 2021 21:55:07 +0100 Message-ID: <596880294af8224f2f28311c39491bdfa3b39f2e.camel@sipsolutions.net> Subject: Re: [PATCH net] iwlwifi: provide gso_type to GSO packets From: Johannes Berg To: Jakub Kicinski Cc: Eric Dumazet , "David S . Miller" , netdev , Eric Dumazet , Ben Greear , Luca Coelho , linux-wireless@vger.kernel.org Date: Tue, 26 Jan 2021 21:55:06 +0100 In-Reply-To: <20210126123207.5c79f4c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210125150949.619309-1-eric.dumazet@gmail.com> <20210126123207.5c79f4c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote: > On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote: > > From: Eric Dumazet > > > > net/core/tso.c got recent support for USO, and this broke iwlfifi > > because the driver implemented a limited form of GSO. > > > > Providing ->gso_type allows for skb_is_gso_tcp() to provide > > a correct result. > > > > Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support") > > Signed-off-by: Eric Dumazet > > Reported-by: Ben Greear > > Bisected-by: Ben Greear > > Tested-by: Ben Greear > > Cc: Luca Coelho > > Cc: linux-wireless@vger.kernel.org > > Cc: Johannes Berg > > Johannes, Eric tagged this for net, are you okay with me taking it? > No strong preference here. I guess that really would normally go through Luca's and Kalle's trees, but yes, please just take it, it's been long and it won't conflict with anything. johannes