From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Wright Feng <wright.feng@cypress.com>,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled
Date: Wed, 02 Aug 2017 12:17:56 +0200 [thread overview]
Message-ID: <5981A6D4.4030805@broadcom.com> (raw)
In-Reply-To: <87mv7i48nx.fsf@codeaurora.org>
On 8/2/2017 11:32 AM, Kalle Valo wrote:
> Wright Feng <wright.feng@cypress.com> writes:
>
>> The num_different_channels in wiphy info is not correct when firmware
>> supports mchan. When mchan is on, num_different_channels is always
>> overridden to 1 in brcmf_setup_ifmodes. Correct the logic by moving
>> num_different_channels setting forward.
>>
>> Signed-off-by: Wright Feng <wright.feng@cypress.com>
>
> Does this fix a user visible bug? If yes, it would be nice to document
> that.
Hi Kalle,
Depends on the users expectation ;-) When the device/firmware supports
multi-channel (better not use mchan abbreviation) it can have P2P
connection and regular connection with AP simultaneous. So the current
state is that this is not possible regardless whether mchan is
supported. So the device is not used to fullest extent.
Regards,
Arend
next prev parent reply other threads:[~2017-08-02 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 8:48 [PATCH 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/opensecurity mode Wright Feng
2017-08-01 8:48 ` [PATCH 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset Wright Feng
2017-08-01 12:43 ` Arend van Spriel
2017-08-01 15:10 ` Chi-Hsien Lin
2017-08-01 21:03 ` Arend van Spriel
2017-08-02 8:15 ` Kalle Valo
2017-08-01 8:48 ` [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled Wright Feng
2017-08-01 12:44 ` Arend van Spriel
2017-08-02 9:32 ` Kalle Valo
2017-08-02 10:17 ` Arend van Spriel [this message]
2017-08-02 13:40 ` Kalle Valo
2017-08-03 1:57 ` Wright Feng
2017-08-01 12:41 ` [PATCH 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/opensecurity mode Arend van Spriel
2017-08-02 2:56 ` Wright Feng
2017-08-02 9:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5981A6D4.4030805@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).