From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: kvalo@codeaurora.org, Larry.Finger@lwfinger.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4] rtlwifi: Replace hardcode value with macro
Date: Wed, 02 Aug 2017 14:10:53 +0200 [thread overview]
Message-ID: <5981C14D.8030400@broadcom.com> (raw)
In-Reply-To: <20170802115921.GA4381@symbol-HP-ZBook-15>
On 8/2/2017 1:59 PM, Souptick Joarder wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro and removed the comment.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++---
> drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++
> 2 files changed, 4 insertions(+), 3 deletions(-)
[...]
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.h b/drivers/net/wireless/realtek/rtlwifi/base.h
> index ab7d819..c591d75 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.h
> @@ -65,6 +65,8 @@ enum ap_peer {
> #define FRAME_OFFSET_ADDRESS3 16
> #define FRAME_OFFSET_SEQUENCE 22
> #define FRAME_OFFSET_ADDRESS4 24
> +#define MAX_LISTEN_INTERVAL 10
> +#define MAX_RATE_TRIES 4
It is not so nice to mix tabs and spaces like that. Better adhere to the
existing convention.
Regards,
Arend
next prev parent reply other threads:[~2017-08-02 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:59 [PATCH v4] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-08-02 12:10 ` Arend van Spriel [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-07-31 11:14 Souptick Joarder
2017-07-31 14:18 ` Larry Finger
2017-08-02 9:21 ` Kalle Valo
2017-08-02 10:47 ` Souptick Joarder
2017-08-02 10:50 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5981C14D.8030400@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=jrdr.linux@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).