From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Simon Shields <simon@lineageos.org>
Cc: linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, devicetree@vger.kernel.org,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>
Subject: Re: [PATCH] brcmfmac: add support for external 32khz clock
Date: Tue, 7 Nov 2017 12:09:23 +0100 [thread overview]
Message-ID: <5A019463.9060701@broadcom.com> (raw)
In-Reply-To: <20171106112726.GA25134@lineageos.org>
On 11/6/2017 12:27 PM, Simon Shields wrote:
> On Mon, Nov 06, 2017 at 11:59:37AM +0100, Arend van Spriel wrote:
>> On 11/4/2017 2:24 PM, Simon Shields wrote:
>>> Some boards use an external 32khz clock for low-power
>>> mode timing. Make sure the clock is powered on while the chipset
>>> is active.
>>
>> Do you have such a board? With the little documentation I can get my hands
>> on here I wonder whether the clock needs to be enabled before the device is
>> powered. If you have the hardware I would like to check some registers in
>> the device.
>>
>
> Yes. Trats2 (exynos4412-based) has such a setup. The BCM4334 works fine
> with this patch and one more that enables the WL_REG_EN pin when
> brcmfmac is probed.
Ok. So this is exactly the thing I was wondering about. So it makes me
curious how the WL_REG_EN patch looks like. Can you provide that?
> Without this patch (and only enabling WL_REG_EN), the chip is detected but
> attempting to initialise it fails with a bunch of timeouts.
I would be interested in seeing a detailed log of that. Could you
provide that? You need to build the driver with CONFIG_BRCMDBG and pass
module parameter 'debug=0x1416' upon insmod/modprobe.
Regards,
Arend
next prev parent reply other threads:[~2017-11-07 11:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 13:24 [PATCH] brcmfmac: add support for external 32khz clock Simon Shields
2017-11-06 9:42 ` Kalle Valo
2017-11-06 10:59 ` Arend van Spriel
2017-11-06 11:27 ` Simon Shields
2017-11-07 11:09 ` Arend van Spriel [this message]
2017-11-07 13:31 ` Simon Shields
2017-11-08 10:38 ` Arend van Spriel
2017-11-08 11:43 ` Simon Shields
2017-11-08 13:31 ` Simon Shields
2017-11-06 18:34 ` Stefan Wahren
2017-11-07 2:18 ` Kalle Valo
2017-11-07 6:52 ` Stefan Wahren
2017-11-07 9:01 ` Arend van Spriel
2017-11-08 0:30 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-11-06 10:29 Simon Shields
2017-11-06 10:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A019463.9060701@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=devicetree@vger.kernel.org \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=simon@lineageos.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).