From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
linux-wireless@vger.kernel.org
Cc: Kalle Valo <kvalo@codeaurora.org>,
brcm80211-dev-list@cypress.com,
brcm80211-dev-list.pdl@broadcom.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com,
Wright Feng <Wright.Feng@cypress.com>,
Stanley Hsu <Stanley.Hsu@cypress.com>
Subject: Re: [PATCH] brcmfmac: Add sg parameters dts parsing
Date: Fri, 1 Dec 2017 09:38:32 +0100 [thread overview]
Message-ID: <5A211508.6030603@broadcom.com> (raw)
In-Reply-To: <20171201075542.GA31376@aremote07.aus.cypress.com>
On 12/1/2017 8:55 AM, Chi-Hsien Lin wrote:
> broken_sg_support, sd_head_align, and sd_sgentry_align are used in
> brcmfmac code but not configurable in dts file. Add the parsing logic.
> Now they can be configured like below in dts:
> brcm,broken_sg_support;
> brcm,sd_head_align =/bits/ 16 <4>;
> brcm,sd_sgentry_align =/bits/ 16 <4>;
Hi Chi-Hsien,
For device tree support you should submit a separate commit on the dt
binding specification. For broadcom fullmac chipsets binding spec can be
found in
Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt.
The alignment properties are to be specified in bytes, not bits.
Regards,
Arend
next prev parent reply other threads:[~2017-12-01 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 7:55 [PATCH] brcmfmac: Add sg parameters dts parsing Chi-Hsien Lin
2017-12-01 8:38 ` Arend van Spriel [this message]
2017-12-02 14:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A211508.6030603@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Stanley.Hsu@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).