linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: William Dauchy <wdauchy@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: brcmfmac: set p2p_disc error on BCM4350
Date: Mon, 8 Jan 2018 10:31:52 +0100	[thread overview]
Message-ID: <5A533A88.1000804@broadcom.com> (raw)
In-Reply-To: <CAJ75kXYLOV8aVZpftBFRbMv=KCaxCoQpJFaL0m0QDjVOytq3Vg@mail.gmail.com>

On 1/8/2018 12:49 AM, William Dauchy wrote:
> Hello,
>
> Using the last v4.14.x I am getting this error at each boot, on my
> BCM4350 802.11ac Wireless Network Adapter:
>
> brcmfmac: brcmf_p2p_create_p2pdev: set p2p_disc error
> brcmfmac: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp58s0 type 10
> failed: err=-16
>
> The firmware used is:
> brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Oct 22 2015
> 06:16:26 version 7.35.180.119 (r594535) FWID 01-e791c176
>
> I was wondering if this error could be fixed?

This has been reported before, but not been able to look into it. Diving 
into firmware it seems that error can only occur if the mac address for 
the p2pdev interface is already used. So if possible can you rebuild the 
driver with the patch below applied and provide dmesg output and output 
of 'ifconfig -a'.

Regards,
Arend
---8<----------------------------------------------------------------

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c 
b/drivers/n
index 2ee5413..f96ad37 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2065,6 +2065,7 @@ static struct wireless_dev 
*brcmf_p2p_create_p2pdev(struc
         int err;
         u32 bsscfgidx;

+       brcmf_err("enter: mac=%pM\n", addr);
         if (p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif)
                 return ERR_PTR(-ENOSPC);

  reply	other threads:[~2018-01-08  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07 23:49 brcmfmac: set p2p_disc error on BCM4350 William Dauchy
2018-01-08  9:31 ` Arend van Spriel [this message]
2018-01-08 10:30   ` William Dauchy
2018-01-15 10:29     ` William Dauchy
2018-01-15 19:48       ` Arend van Spriel
2018-01-15 20:03         ` William Dauchy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A533A88.1000804@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wdauchy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).