From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: pkshih@realtek.com, kvalo@codeaurora.org
Cc: Larry.Finger@lwfinger.net, yhchuang@realtek.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 02/10] rtlwifi: fix scan channel 1 fail after IPS
Date: Wed, 10 Jan 2018 09:12:49 +0100 [thread overview]
Message-ID: <5A55CB01.5040504@broadcom.com> (raw)
In-Reply-To: <20180110052002.9544-3-pkshih@realtek.com>
On 1/10/2018 6:19 AM, pkshih@realtek.com wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> If there is no connection, driver will enter IPS state. Meanwhile, it
> fails to scan channel 1 by the command 'iw dev wlan0 scan freq 2412',
> because hardware channel setting lose after IPS. Thus, restore channel
> setting from hw->conf.channel set by last rtl_op_config().
>
> Signed-off-by: Tim Lee <timlee@realtek.com>
You need to add your sob here as well as you are submitting them.
> ---
> drivers/net/wireless/realtek/rtlwifi/ps.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c
> index 6a4008845f49..0ffe43772c9a 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/ps.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
> @@ -51,6 +51,12 @@ bool rtl_ps_enable_nic(struct ieee80211_hw *hw)
> &rtlmac->retry_long);
> RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC);
>
> + /*<2.1> Switch Channel & Bandwidth to last rtl_op_config setting*/
Is this type of comment really helpful? To me it seems the callback
names provide enough context.
Regards,
Arend
> + rtlpriv->cfg->ops->switch_channel(hw);
> + rtlpriv->cfg->ops->set_channel_access(hw);
> + rtlpriv->cfg->ops->set_bw_mode(hw,
> + cfg80211_get_chandef_type(&hw->conf.chandef));
> +
> /*<3> Enable Interrupt */
> rtlpriv->cfg->ops->enable_interrupt(hw);
>
>
next prev parent reply other threads:[~2018-01-10 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 5:19 [PATCH 00/10] rtlwifi: fix some bugs and add btcoex functions pkshih
2018-01-10 5:19 ` [PATCH 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS pkshih
2018-01-10 5:19 ` [PATCH 02/10] rtlwifi: fix scan channel 1 fail after IPS pkshih
2018-01-10 8:12 ` Arend van Spriel [this message]
2018-01-10 9:38 ` Pkshih
2018-01-10 14:08 ` Arend van Spriel
2018-01-11 1:22 ` Pkshih
2018-01-10 5:19 ` [PATCH 03/10] rtlwifi: Add sta_statistics of mac80211's op, and set filled=0 by default pkshih
2018-01-10 5:19 ` [PATCH 04/10] rtlwifi: unlink bss when un-association pkshih
2018-01-10 5:19 ` [PATCH 05/10] rtlwifi: enable mac80211 fast-tx support pkshih
2018-01-10 8:14 ` Arend van Spriel
2018-01-10 5:19 ` [PATCH 06/10] rtlwifi: Support A-MSDU in A-MPDU capability pkshih
2018-01-10 5:19 ` [PATCH 07/10] rtlwifi: btcoex: Add power_on_setting routine pkshih
2018-01-10 5:20 ` [PATCH 08/10] rtlwifi: btcoex: Remove global variables from btcoex pkshih
2018-01-10 5:20 ` [PATCH 09/10] rtlwifi: btcoex: Add common function for qeurying BT information pkshih
2018-01-10 5:20 ` [PATCH 10/10] rtlwifi: btcoex: add rfe_type parameter to btcoex pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A55CB01.5040504@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).