From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Sergei Maksimenko <smaksimenko@quantenna.com>,
Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>,
linux-wireless@vger.kernel.org
Cc: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>
Subject: Re: [PATCH 5/6] qtnfmac: implement asynchronous firmware loading
Date: Thu, 8 Feb 2018 10:51:12 +0100 [thread overview]
Message-ID: <5A7C1D90.6060401@broadcom.com> (raw)
In-Reply-To: <9e2bbb8c-b34f-a93a-873a-6f5e744669ec@quantenna.com>
On 2/7/2018 12:09 PM, Sergei Maksimenko wrote:
> Hi Arend,
>
> Qsr10g devices support loading firmware not only from the host over PCIe
> but also from on-board flash.
> Firmware start-up sequence and the following handshake are common for
> PCIe and flash boot modes. They take much more
> time (about 10 seconds) than the firmware upload process.
> To make flash mode startup also asynchronous we can't use the existing
> API such as request_firmware_nowait() as there is
> no firmware to upload, and have to explicitly run the needed functions
> in a work queue.
> In my opinion it is more neat to have one firmware load function invoked
> in a work queue for both modes than using
> request_firmware_nowait() for one mode only.
I was taught "neat" is not a real argument ;-) I agree that if you need
the worker for async flashing it makes sense to use that for async
firmware loading as well. Missed that reading the patch itself.
Regards,
Arend
> Regards,
> Sergei
>
> On 06.02.2018 14:22, Arend van Spriel wrote:
>>
>> External Email
>>
>>
>> On 2/5/2018 4:05 PM, Sergey Matyukevich wrote:
>>> From: Sergei Maksimenko <smaksimenko@quantenna.com>
>>>
>>> In pci probe() function start firmware loading, protocol handshake
>>> and driver core initialization, and not wait for completion.
>>
>> The moving of the debugfs stuff makes this a drag to review, but I get
>> the gist. The thing is that the firmware api already provides an
>> asynchronous api, ie. request_firmware_nowait(), so why not use that.
>>
>> Regards,
>> Arend
>
>
>
> This email, including its contents and any attachment(s), may contain
> confidential information of Quantenna Communications, Inc. and is solely
> for the intended recipient(s). If you may have received this in error,
> please contact the sender and permanently delete this email, its
> contents and any attachment(s).
next prev parent reply other threads:[~2018-02-08 9:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 15:05 [PATCH 0/6] qtnfmac: qsr10g pcie backend updates Sergey Matyukevich
2018-02-05 15:05 ` [PATCH 1/6] qtnfmac: fix releasing Tx/Rx data buffers Sergey Matyukevich
2018-02-05 15:05 ` [PATCH 2/6] qtnfmac: enable reloading of qtnfmac kernel modules Sergey Matyukevich
2018-02-05 15:05 ` [PATCH 3/6] qtnfmac: fix rmmod for firmware version mismatch Sergey Matyukevich
2018-02-05 15:05 ` [PATCH 4/6] qtnfmac: fix rmmod for missing firmware Sergey Matyukevich
2018-02-06 11:18 ` Arend van Spriel
2018-02-08 9:06 ` Sergey Matyukevich
2018-02-08 9:21 ` Arend van Spriel
2018-02-05 15:05 ` [PATCH 5/6] qtnfmac: implement asynchronous firmware loading Sergey Matyukevich
2018-02-06 11:22 ` Arend van Spriel
2018-02-07 11:09 ` Sergei Maksimenko
2018-02-08 9:51 ` Arend van Spriel [this message]
2018-02-05 15:05 ` [PATCH 6/6] qtnfmac: enable networked standby mode on device inactivity Sergey Matyukevich
2018-02-27 14:28 ` [PATCH 0/6] qtnfmac: qsr10g pcie backend updates Kalle Valo
2018-02-27 14:37 ` Sergey Matyukevich
2018-02-27 16:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A7C1D90.6060401@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=avinashp@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
--cc=smaksimenko@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).