From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] brcmfmac: reject too long PSK
Date: Wed, 21 Feb 2018 09:44:07 +0100 [thread overview]
Message-ID: <5A8D3157.7080208@broadcom.com> (raw)
In-Reply-To: <20180219123045.8818-1-johannes@sipsolutions.net>
On 2/19/2018 1:30 PM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> nl80211 already allows specifying 48 bytes, but brcmfmac
> only supports 32. Reject keys that are too long.
Hah. Recent discussion about the key length made you look ;-) Thanks!
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 15fa00d79fc6..74a83020c073 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5124,6 +5124,9 @@ static int brcmf_cfg80211_set_pmk(struct wiphy *wiphy, struct net_device *dev,
> if (WARN_ON(ifp->vif->profile.use_fwsup != BRCMF_PROFILE_FWSUP_1X))
> return -EINVAL;
>
> + if (conf->pmk_len > BRCMF_WSEC_MAX_PSK_LEN)
> + return -ERANGE;
> +
> return brcmf_set_pmk(ifp, conf->pmk, conf->pmk_len);
> }
>
>
next prev parent reply other threads:[~2018-02-21 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 12:30 [PATCH] brcmfmac: reject too long PSK Johannes Berg
2018-02-21 8:44 ` Arend van Spriel [this message]
2018-02-27 16:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A8D3157.7080208@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).