From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] brcmfmac: add possibility to obtain firmware error
Date: Wed, 28 Feb 2018 10:07:47 +0100 [thread overview]
Message-ID: <5A967163.7010206@broadcom.com> (raw)
In-Reply-To: <1519774940-20793-2-git-send-email-arend.vanspriel@broadcom.com>
On 2/28/2018 12:42 AM, Arend van Spriel wrote:
> The feature module needs to evaluate the actual firmware error returned
> upon a control command. This adds a field to struct brcmf_if in which
> the error code is stored whenever a firmware error occurs.
Hi Kalle,
Can you drop this one. It was way too late for me so I screwed it up. If
needed I will resend both patches. Let me know.
Regards,
Arend
> Fixes: b69c1df47281 ("brcmfmac: separate firmware errors from i/o errors")
> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h | 2 ++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c | 1 +
> 3 files changed, 4 insertions(+), 1 deletion(-)
next prev parent reply other threads:[~2018-02-28 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:42 [PATCH for-4.16 0/2] brcmfmac: small fixes Arend van Spriel
2018-02-27 23:42 ` [PATCH 1/2] brcmfmac: add possibility to obtain firmware error Arend van Spriel
2018-02-28 9:07 ` Arend van Spriel [this message]
2018-02-28 11:40 ` Kalle Valo
2018-02-27 23:42 ` [PATCH 2/2] brcmfmac: fix P2P_DEVICE ethernet address generation Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A967163.7010206@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).