From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Andres Rodriguez <andresx7@gmail.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Ilia Mirkin <imirkin@alum.mit.edu>
Subject: Re: [PATCH] firmware: add a function to load optional firmware v2
Date: Mon, 12 Mar 2018 00:10:47 +0100 [thread overview]
Message-ID: <5AA5B777.5020106@broadcom.com> (raw)
In-Reply-To: <bbdc304f-edd5-38df-ea88-012fefc54b90@gmail.com>
On 3/11/2018 5:05 PM, Andres Rodriguez wrote:
>> Your patch series then should also have the driver callers who you
>> want to modify to use this new API. Collect from the 802.11 folks the
>> other drivers which I think they wanted changed as well.
>
> Arend, Kalle, would love to hear your feedback.
I am not sure if it was ath10k, but Kalle will surely know. The other
driver firing a whole batch of firmware requests is iwlwifi. These
basically try to get latest firmware version and if not there try an
older one.
The brcmfmac driver I maintain is slightly different. It downloads two
distinct pieces of firmware of which one is optional for certain
configurations. Currently, my driver does two asynchronous requests for
it, but I consider changing it and only make the first request
asynchronous and the second request synchronous. You can look at the
current code in drivers/net/wireless/broadcom/brcmfmac/firmware.c.
However, I did quite some restructuring last week. Anyway, I probably
will end up using the "optional" api where appropriate.
Regards,
Arend
next prev parent reply other threads:[~2018-03-11 23:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180309221243.15489-2-andresx7@gmail.com>
[not found] ` <20180309230925.3573-1-andresx7@gmail.com>
2018-03-10 14:35 ` [PATCH] firmware: add a function to load optional firmware v2 Luis R. Rodriguez
2018-03-10 14:40 ` Luis R. Rodriguez
2018-03-11 16:05 ` Andres Rodriguez
2018-03-11 23:10 ` Arend van Spriel [this message]
2018-03-12 19:27 ` Luis R. Rodriguez
2018-03-13 13:39 ` Kalle Valo
2018-03-13 16:38 ` Luis R. Rodriguez
2018-03-20 2:21 ` Andres Rodriguez
2018-03-13 13:35 ` Kalle Valo
2018-03-13 13:16 ` Kalle Valo
2018-03-13 16:40 ` Luis R. Rodriguez
2018-03-13 16:46 ` Kalle Valo
2018-03-14 8:24 ` Arend van Spriel
2018-03-14 8:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AA5B777.5020106@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=andresx7@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imirkin@alum.mit.edu \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).