From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Takashi Iwai <tiwai@suse.de>, linux-wireless@vger.kernel.org
Cc: Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com
Subject: Re: [PATCH] brcmsmac: allocate ucode with GFP_KERNEL
Date: Fri, 16 Mar 2018 21:50:43 +0100 [thread overview]
Message-ID: <5AAC2E23.5020505@broadcom.com> (raw)
In-Reply-To: <20180316154149.16891-1-tiwai@suse.de>
On 3/16/2018 4:41 PM, Takashi Iwai wrote:
> The brcms_ucode_init_buf() duplicates the ucode chunks via kmemdup()
> with GFP_ATOMIC as a precondition of wl->lock acquired. This caused
> allocation failures sometimes as reported in the bugzilla below.
>
> When looking at the the real usage, one can find that it's called
> solely from brcms_request_fw(), and it's obviously outside the lock.
> Hence we can use GFP_KERNEL there safely for avoiding such allocation
> errors.
>
> Bugzilla: http://bugzilla.suse.com/show_bug.cgi?id=1085174
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2018-03-16 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 15:41 [PATCH] brcmsmac: allocate ucode with GFP_KERNEL Takashi Iwai
2018-03-16 20:50 ` Arend van Spriel [this message]
2018-03-27 9:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AAC2E23.5020505@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).